Macro with same name in rust-bitcoin is quite different

[tcharding]

In rust-bitcoin we have a macro name the same as one here impl_array_newtype but they differ substantially.

Should they be the same?

The one in rust-bitcoin was patched in rust-bitcoin/rust-bitcoin#2585

[apoelstra]

Yeah, these should be the same.

It's tempting to move the macro into internals but right now hashes does not have an internals dep. So maybe ok to continue having the macro be copy/pasted. But maybe we should have a lint check to verify that the code is identical?

[tcharding]

The macro is in internals, and I just realized there are two of them in secp, one in each crate.

Oh, did you mean secp256k1 doesn't have a dependency on internals?

[apoelstra]

Oh, yeah, I was confusing hashes (which has yet another macro that serves a similar purpose..) with secp256k1.