From 39fb959a4fb7738a60a5b086b3d1d73a9efbc6d1 Mon Sep 17 00:00:00 2001 From: blyxyas Date: Mon, 19 May 2025 17:07:06 +0000 Subject: [PATCH 1/5] Add "The incoming Summer of Clippy" post --- content/the-incoming-summer-of-clippy.md | 62 ++++++++++++++++++++++++ 1 file changed, 62 insertions(+) create mode 100644 content/the-incoming-summer-of-clippy.md diff --git a/content/the-incoming-summer-of-clippy.md b/content/the-incoming-summer-of-clippy.md new file mode 100644 index 000000000..907dd29c7 --- /dev/null +++ b/content/the-incoming-summer-of-clippy.md @@ -0,0 +1,62 @@ ++++ +path = "9999/12/31/the-incoming-summer-of-clippy" +title = "The incoming Summer of Clippy" +authors = ["blyxyas"] + +[extra] +team = "the Clippy team" +team_url = "https://www.rust-lang.org/governance/teams/dev-tools#team-clippy" ++++ + +We are currently working on a feature freeze for the Clippy project. This +period would be 12 weeks long, starting on the introduction of 1.89 to beta +on the 26 of June, and ending on the 18th of September. + +This *summer of Clippy* comes from a lack of the necessary capacity needed +to maintain all the current lints (about 750 of them 😱) and still add new ones. +We need to care for the Clippy project the same way that Clippy cares about our +code, and note that every single one of them needs maintaining and accounting +for current and future changes in the compiler as a whole. + +As a team we’ll focus on making contributing the best it can be, we’ll try to +bisect all the issues possible and mark the issues that could be great as a +starting point to get familiar with the project. + +## What can I expect as a user? + +As a user you can expect to have more accurate lints, with less false negatives +and more edge cases covered. A bump into Clippy’s toolchain would not involve +the same risk for false positives as it has been until now. We hope that by +upping the standard for lints all around the project we can allow users to +expect even more from the already great linter. + +If you have a lint which you want to be implemented, you can still open and +issue for it, but no one will implement it (also, lint-adding pull requests +opened after the starting date will be blocked for the duration of the period) + +Note that pull requests opened before the starting date can still be reviewed +and merged, but unless they are already in a very advanced state they will not +be priorized over bugfixes. + +## Can I help? + +As always, any help on the project is very appreciated. Apart from opening bug +reports, you can follow our [contributing guidelines] and check [our suggested +good first issues] for opening pull requests . Everything from fixing diagnostic +issues and improving documentation, to fixing application-wide crashes +really helps Clippy get into the excellent state that our users deserve. + +If you need direct help when fixing a bug, don't hesitate to open a thread on +Zulip, or to open the PR with the questions you have in order to start the +feedback stream. + +## Conclusion + +Thanks a lot for all these years of supporting Clippy, we hope that via this +little feature hiatus we can achieve the excellence that the Rust user base +deserves (if that's even possible). + +[contributing guidelines]: https://github.com/rust-lang/rust-clippy/blob/master/CONTRIBUTING.md +[our suggested good first issues]: + + From 4a0c77f93cb324ac198f24098b886608e5c22a43 Mon Sep 17 00:00:00 2001 From: blyxyas Date: Mon, 19 May 2025 22:27:43 +0000 Subject: [PATCH 2/5] Fix typos --- content/the-incoming-summer-of-clippy.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/content/the-incoming-summer-of-clippy.md b/content/the-incoming-summer-of-clippy.md index 907dd29c7..6c13c051a 100644 --- a/content/the-incoming-summer-of-clippy.md +++ b/content/the-incoming-summer-of-clippy.md @@ -30,13 +30,13 @@ the same risk for false positives as it has been until now. We hope that by upping the standard for lints all around the project we can allow users to expect even more from the already great linter. -If you have a lint which you want to be implemented, you can still open and +If you have a lint which you want to be implemented, you can still open an issue for it, but no one will implement it (also, lint-adding pull requests -opened after the starting date will be blocked for the duration of the period) +opened after the starting date will be blocked for the duration of the period). Note that pull requests opened before the starting date can still be reviewed and merged, but unless they are already in a very advanced state they will not -be priorized over bugfixes. +be prioritized over bugfixes. ## Can I help? From 8cc70cfe92e262413b22d480c34150d87e43b328 Mon Sep 17 00:00:00 2001 From: blyxyas Date: Wed, 21 May 2025 11:35:26 +0000 Subject: [PATCH 3/5] Fix typos & rephrase 2, electric bogaloo --- content/the-incoming-summer-of-clippy.md | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/content/the-incoming-summer-of-clippy.md b/content/the-incoming-summer-of-clippy.md index 6c13c051a..c47f180bb 100644 --- a/content/the-incoming-summer-of-clippy.md +++ b/content/the-incoming-summer-of-clippy.md @@ -18,9 +18,8 @@ We need to care for the Clippy project the same way that Clippy cares about our code, and note that every single one of them needs maintaining and accounting for current and future changes in the compiler as a whole. -As a team we’ll focus on making contributing the best it can be, we’ll try to -bisect all the issues possible and mark the issues that could be great as a -starting point to get familiar with the project. +As a team we’ll focus on making contributing the best it can be, and mark the +issues that could be great as a starting point to get familiar with the project. ## What can I expect as a user? @@ -41,7 +40,7 @@ be prioritized over bugfixes. ## Can I help? As always, any help on the project is very appreciated. Apart from opening bug -reports, you can follow our [contributing guidelines] and check [our suggested +reports, you can follow [our contributing guidelines] and check [our suggested good first issues] for opening pull requests . Everything from fixing diagnostic issues and improving documentation, to fixing application-wide crashes really helps Clippy get into the excellent state that our users deserve. @@ -56,7 +55,7 @@ Thanks a lot for all these years of supporting Clippy, we hope that via this little feature hiatus we can achieve the excellence that the Rust user base deserves (if that's even possible). -[contributing guidelines]: https://github.com/rust-lang/rust-clippy/blob/master/CONTRIBUTING.md +[our contributing guidelines]: https://github.com/rust-lang/rust-clippy/blob/master/CONTRIBUTING.md [our suggested good first issues]: From 20bdc4de7e50eb863f59b61b6d6443b0741f2a3a Mon Sep 17 00:00:00 2001 From: blyxyas Date: Thu, 22 May 2025 19:06:09 +0000 Subject: [PATCH 4/5] Follow review comments --- content/the-incoming-summer-of-clippy.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/content/the-incoming-summer-of-clippy.md b/content/the-incoming-summer-of-clippy.md index c47f180bb..a3c49a350 100644 --- a/content/the-incoming-summer-of-clippy.md +++ b/content/the-incoming-summer-of-clippy.md @@ -8,9 +8,9 @@ team = "the Clippy team" team_url = "https://www.rust-lang.org/governance/teams/dev-tools#team-clippy" +++ -We are currently working on a feature freeze for the Clippy project. This -period would be 12 weeks long, starting on the introduction of 1.89 to beta -on the 26 of June, and ending on the 18th of September. +The Clippy project will be on feature-freeze for 12 weeks, starting from Rust +1.89.0 beta (June 26th 2025) to September 18th 2025 (Rust 1.89.0 stable +release). During this time no new features will be accepted, only bug fixes. This *summer of Clippy* comes from a lack of the necessary capacity needed to maintain all the current lints (about 750 of them 😱) and still add new ones. From 297b6fd718401830197f68b3ca9580d53907d5a7 Mon Sep 17 00:00:00 2001 From: blyxyas Date: Tue, 27 May 2025 22:28:49 +0000 Subject: [PATCH 5/5] Review comments 2 --- ...> announcing-the-clippy-feature-freeze.md} | 30 +++++++++---------- 1 file changed, 15 insertions(+), 15 deletions(-) rename content/{the-incoming-summer-of-clippy.md => announcing-the-clippy-feature-freeze.md} (69%) diff --git a/content/the-incoming-summer-of-clippy.md b/content/announcing-the-clippy-feature-freeze.md similarity index 69% rename from content/the-incoming-summer-of-clippy.md rename to content/announcing-the-clippy-feature-freeze.md index a3c49a350..849e01e38 100644 --- a/content/the-incoming-summer-of-clippy.md +++ b/content/announcing-the-clippy-feature-freeze.md @@ -1,6 +1,6 @@ +++ -path = "9999/12/31/the-incoming-summer-of-clippy" -title = "The incoming Summer of Clippy" +path = "9999/12/31/announcing-the-clippy-feature-freeze" +title = "Announcing the Clippy feature freeze" authors = ["blyxyas"] [extra] @@ -12,8 +12,8 @@ The Clippy project will be on feature-freeze for 12 weeks, starting from Rust 1.89.0 beta (June 26th 2025) to September 18th 2025 (Rust 1.89.0 stable release). During this time no new features will be accepted, only bug fixes. -This *summer of Clippy* comes from a lack of the necessary capacity needed -to maintain all the current lints (about 750 of them 😱) and still add new ones. +This *feature freeze* comes from a lack of the necessary capacity needed +to maintain all the current lints (over 750 of them 😱) and still add new ones. We need to care for the Clippy project the same way that Clippy cares about our code, and note that every single one of them needs maintaining and accounting for current and future changes in the compiler as a whole. @@ -23,39 +23,39 @@ issues that could be great as a starting point to get familiar with the project. ## What can I expect as a user? -As a user you can expect to have more accurate lints, with less false negatives +As a user you can expect to have more accurate lints, with less false positives and more edge cases covered. A bump into Clippy’s toolchain would not involve the same risk for false positives as it has been until now. We hope that by upping the standard for lints all around the project we can allow users to expect even more from the already great linter. If you have a lint which you want to be implemented, you can still open an -issue for it, but no one will implement it (also, lint-adding pull requests -opened after the starting date will be blocked for the duration of the period). +issue for it, but PRs adding new lints won't be reviewed during the feature +freeze. Instead, they will be put into a queue and reviewed (and merged) after +the feature freeze is over. -Note that pull requests opened before the starting date can still be reviewed -and merged, but unless they are already in a very advanced state they will not -be prioritized over bugfixes. +> Open pull requests that add new lints and are in a **very** advanced state +> might still get reviewed and/or merged during the feature freeze. ## Can I help? As always, any help on the project is very appreciated. Apart from opening bug reports, you can follow [our contributing guidelines] and check [our suggested -good first issues] for opening pull requests . Everything from fixing diagnostic +good first issues] for opening pull requests. Everything from fixing diagnostic issues and improving documentation, to fixing application-wide crashes really helps Clippy get into the excellent state that our users deserve. If you need direct help when fixing a bug, don't hesitate to open a thread on -Zulip, or to open the PR with the questions you have in order to start the -feedback stream. +[Zulip] and/or open a draft PR with the questions you have in order to start +the feedback stream. ## Conclusion Thanks a lot for all these years of supporting Clippy, we hope that via this little feature hiatus we can achieve the excellence that the Rust user base -deserves (if that's even possible). +deserves. [our contributing guidelines]: https://github.com/rust-lang/rust-clippy/blob/master/CONTRIBUTING.md [our suggested good first issues]: - +[Zulip]: https://rust-lang.zulipchat.com/#narrow/channel/257328-clippy