refactor(shell): Allow callers to opt-in to quiet filtering

Author: epage

src/cargo/core/shell.rs

@@ -404,7 +404,11 @@ impl Shell {
     }
 
     /// Prints the passed in [`Report`] to stderr
-    pub fn print_report(&mut self, report: Report<'_>) -> CargoResult<()> {
+    pub fn print_report(&mut self, report: Report<'_>, force: bool) -> CargoResult<()> {
+        if !force && matches!(self.verbosity, Verbosity::Quiet) {
+            return Ok(());
+        }
+
         if self.needs_clear {
             self.err_erase_line();
         }

src/cargo/util/lints.rs

@@ -171,7 +171,7 @@ fn verify_feature_enabled(
         }
 
         *error_count += 1;
-        gctx.shell().print_report(&report)?;
+        gctx.shell().print_report(&report, true)?;
     }
     Ok(())
 }
@@ -339,6 +339,15 @@ impl LintLevel {
             LintLevel::Forbid => Level::ERROR,
         }
     }
+
+    fn force(self) -> bool {
+        match self {
+            Self::Allow => false,
+            Self::Warn => true,
+            Self::Deny => true,
+            Self::Forbid => true,
+        }
+    }
 }
 
 impl From<TomlLintLevel> for LintLevel {
@@ -459,7 +468,7 @@ pub fn check_im_a_teapot(
             )
             .element(Level::NOTE.message(&emitted_reason))];
 
-        gctx.shell().print_report(report)?;
+        gctx.shell().print_report(report, lint_level.force())?;
     }
     Ok(())
 }
@@ -568,7 +577,7 @@ fn output_unknown_lints(
             );
         }
 
-        gctx.shell().print_report(&report)?;
+        gctx.shell().print_report(&report, lint_level.force())?;
     }
 
     Ok(())

src/cargo/util/toml/mod.rs

@@ -1932,7 +1932,7 @@ fn missing_dep_diagnostic(
         group.element(snippet)
     };
 
-    if let Err(err) = gctx.shell().print_report(&[group]) {
+    if let Err(err) = gctx.shell().print_report(&[group], true) {
         return Err(err.into());
     }
     Err(AlreadyPrintedError::new(anyhow!("").into()).into())
@@ -2800,7 +2800,7 @@ fn emit_diagnostic(
             .annotation(AnnotationKind::Primary.span(span)),
     );
 
-    if let Err(err) = gctx.shell().print_report(&[group]) {
+    if let Err(err) = gctx.shell().print_report(&[group], true) {
         return err.into();
     }
     return AlreadyPrintedError::new(e.into()).into();