fix(install): return error when rev is in git url

return error if the git url contains a # and hint user to use --rev

Author: dawedawe

src/bin/cargo/commands/install.rs

@@ -173,6 +173,14 @@ pub fn exec(gctx: &mut GlobalContext, args: &ArgMatches) -> CliResult {
 
     let source = if let Some(url) = args.get_one::<String>("git") {
         let url = url.into_url()?;
+        if url.fragment().is_some() {
+            return Err(anyhow::format_err!(
+                "invalid git url to install from\n\n\
+                    help: use `--rev <SHA>` to specify a commit"
+            )
+            .into());
+        }
+
         let gitref = if let Some(branch) = args.get_one::<String>("branch") {
             GitReference::Branch(branch.clone())
         } else if let Some(tag) = args.get_one::<String>("tag") {

tests/testsuite/install.rs

@@ -2180,16 +2180,11 @@ fn install_git_with_rev_in_url() {
     url.push_str("#0e8d88b5cfc173c5f5a6a0fe0ce1d4e6018600d4");
 
     cargo_process("install --locked --git")
-        .arg(url.to_string())
+        .arg(url)
         .with_stderr_data(str![[r#"
-[UPDATING] git repository `[ROOTURL]/foo#0e8d88b5cfc173c5f5a6a0fe0ce1d4e6018600d4`
-[WARNING] spurious network error (3 tries remaining): failed to resolve path '[ROOT]/foo#0e8d88b5cfc173c5f5a6a0fe0ce1d4e6018600d4': No such file or directory; class=Os (2)
-[WARNING] spurious network error (2 tries remaining): failed to resolve path '[ROOT]/foo#0e8d88b5cfc173c5f5a6a0fe0ce1d4e6018600d4': No such file or directory; class=Os (2)
-[WARNING] spurious network error (1 try remaining): failed to resolve path '[ROOT]/foo#0e8d88b5cfc173c5f5a6a0fe0ce1d4e6018600d4': No such file or directory; class=Os (2)
-[ERROR] failed to clone into: [ROOT]/home/.cargo/git/db/foo-[HASH]
+[ERROR] invalid git url to install from
 
-Caused by:
-  failed to resolve path '[ROOT]/foo#0e8d88b5cfc173c5f5a6a0fe0ce1d4e6018600d4': No such file or directory; class=Os (2)
+[HELP] use `--rev <SHA>` to specify a commit
 
 "#]])
         .with_status(101)