Skip to content

Unstably support MIR-only rlibs #713

Closed
@saethlin

Description

@saethlin
Member

This a spiritual successor to rust-lang/rust#38913 (implementation at rust-lang/rust#48373). I didn't intend to pick up that PR, I've just heard "MIR-only rlibs" often and the idea seems to solve a number of problems. The old tracking issue says to make an MCP, so here's one.

Proposal

Unlike the previous tracking issue, at this time I am not intending to make MIR-only rlibs the default behavior, or the behavior of the distributed standard library. @eddyb convinced me that even if the feature is nightly-only, it will be useful to the community.

In-progress implementation: rust-lang/rust#119017

If I ever become convinced that MIR-only rlibs are viable as the default behavior of rustc, or the default way that we distribute the standard library, I will create a new MCP.

Mentors or Reviewers

I don't think it will be particularly hard for me to find help on this when I get stuck, but if someone wants to volunteer I'll put a name here.

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Activity

added
T-compilerAdd this label so rfcbot knows to poll the compiler team
major-changeA proposal to make a major change to rustc
on Jan 10, 2024
rustbot

rustbot commented on Jan 10, 2024

@rustbot
Collaborator

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Concerns or objections to the proposal should be discussed on Zulip and formally registered here by adding a comment with the following syntax:

@rustbot concern reason-for-concern 
<description of the concern> 

Concerns can be lifted with:

@rustbot resolve reason-for-concern 

See documentation at https://forge.rust-lang.org

cc @rust-lang/compiler @rust-lang/compiler-contributors

cjgillot

cjgillot commented on Jan 10, 2024

@cjgillot

This is meant to experiment, and the feature has a lot of potential benefits.
@rustbot second

added
final-comment-periodThe FCP has started, most (if not all) team members are in agreement
on Jan 10, 2024
apiraino

apiraino commented on Feb 13, 2024

@apiraino
Contributor

@rustbot label -final-comment-period +major-change-accepted

added
to-announceAnnounce this issue on triage meeting
and removed
final-comment-periodThe FCP has started, most (if not all) team members are in agreement
on Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-compilerAdd this label so rfcbot knows to poll the compiler teammajor-changeA proposal to make a major change to rustcmajor-change-acceptedA major change proposal that was accepted

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @cjgillot@apiraino@saethlin@rustbot

        Issue actions

          Unstably support MIR-only rlibs · Issue #713 · rust-lang/compiler-team