Skip to content

invalidate pages when release is yanked #1862

Closed
@jsha

Description

@jsha
Contributor

Part of #1552, filing as its own issue so we don't forget:

When a crate version is yanked, we should create an invalidation for that crate.

Note: I looked to see how / when we get information about yanks. It looks like it happens in index::Api::get_release_data. But that appears to only get called during builds. Is that right?

Activity

Nemo157

Nemo157 commented on Sep 29, 2022

@Nemo157
Member

Yanks get detected by the "registry watcher" here:

Change::Yanked(release) => {

syphar

syphar commented on Sep 29, 2022

@syphar
Member

This is definitely a gap in the current logic, probably + a crate-delete event.

I would fix this after we merged #1856, but before we introduce the default TTL ( = before we actually start caching)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @Nemo157@jsha@syphar

      Issue actions

        invalidate pages when release is yanked · Issue #1862 · rust-lang/docs.rs