Skip to content

Commit eebac7b

Browse files
bors[bot]lnicola
bors[bot]
and
lnicola
authored
Merge #10712
10712: minor: Avoid deprecated methods in client-side tests r=lnicola a=lnicola Co-authored-by: Laurențiu Nicola <[email protected]>
2 parents 2c29bd7 + 1fe48a7 commit eebac7b

File tree

2 files changed

+25
-25
lines changed

2 files changed

+25
-25
lines changed

‎editors/code/tests/unit/launch_config.test.ts‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -7,46 +7,46 @@ suite('Launch configuration', () => {
77
test('A binary', async () => {
88
const args = Cargo.artifactSpec(["build", "--package", "pkg_name", "--bin", "pkg_name"]);
99

10-
assert.deepEqual(args.cargoArgs, ["build", "--package", "pkg_name", "--bin", "pkg_name", "--message-format=json"]);
11-
assert.deepEqual(args.filter, undefined);
10+
assert.deepStrictEqual(args.cargoArgs, ["build", "--package", "pkg_name", "--bin", "pkg_name", "--message-format=json"]);
11+
assert.deepStrictEqual(args.filter, undefined);
1212
});
1313

1414
test('One of Multiple Binaries', async () => {
1515
const args = Cargo.artifactSpec(["build", "--package", "pkg_name", "--bin", "bin1"]);
1616

17-
assert.deepEqual(args.cargoArgs, ["build", "--package", "pkg_name", "--bin", "bin1", "--message-format=json"]);
18-
assert.deepEqual(args.filter, undefined);
17+
assert.deepStrictEqual(args.cargoArgs, ["build", "--package", "pkg_name", "--bin", "bin1", "--message-format=json"]);
18+
assert.deepStrictEqual(args.filter, undefined);
1919
});
2020

2121
test('A test', async () => {
2222
const args = Cargo.artifactSpec(["test", "--package", "pkg_name", "--lib", "--no-run"]);
2323

24-
assert.deepEqual(args.cargoArgs, ["test", "--package", "pkg_name", "--lib", "--no-run", "--message-format=json"]);
25-
assert.notDeepEqual(args.filter, undefined);
24+
assert.deepStrictEqual(args.cargoArgs, ["test", "--package", "pkg_name", "--lib", "--no-run", "--message-format=json"]);
25+
assert.notDeepStrictEqual(args.filter, undefined);
2626
});
2727
});
2828

2929
suite('QuickPick', () => {
3030
test('A binary', async () => {
3131
const args = Cargo.artifactSpec(["run", "--package", "pkg_name", "--bin", "pkg_name"]);
3232

33-
assert.deepEqual(args.cargoArgs, ["build", "--package", "pkg_name", "--bin", "pkg_name", "--message-format=json"]);
34-
assert.deepEqual(args.filter, undefined);
33+
assert.deepStrictEqual(args.cargoArgs, ["build", "--package", "pkg_name", "--bin", "pkg_name", "--message-format=json"]);
34+
assert.deepStrictEqual(args.filter, undefined);
3535
});
3636

3737

3838
test('One of Multiple Binaries', async () => {
3939
const args = Cargo.artifactSpec(["run", "--package", "pkg_name", "--bin", "bin2"]);
4040

41-
assert.deepEqual(args.cargoArgs, ["build", "--package", "pkg_name", "--bin", "bin2", "--message-format=json"]);
42-
assert.deepEqual(args.filter, undefined);
41+
assert.deepStrictEqual(args.cargoArgs, ["build", "--package", "pkg_name", "--bin", "bin2", "--message-format=json"]);
42+
assert.deepStrictEqual(args.filter, undefined);
4343
});
4444

4545
test('A test', async () => {
4646
const args = Cargo.artifactSpec(["test", "--package", "pkg_name", "--lib"]);
4747

48-
assert.deepEqual(args.cargoArgs, ["test", "--package", "pkg_name", "--lib", "--message-format=json", "--no-run"]);
49-
assert.notDeepEqual(args.filter, undefined);
48+
assert.deepStrictEqual(args.cargoArgs, ["test", "--package", "pkg_name", "--lib", "--message-format=json", "--no-run"]);
49+
assert.notDeepStrictEqual(args.filter, undefined);
5050
});
5151
});
5252
});

‎editors/code/tests/unit/runnable_env.test.ts‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@ function fakePrepareEnv(runnableName: string, config: RunnableEnvCfg): Record<st
2323
suite('Runnable env', () => {
2424
test('Global config works', () => {
2525
const binEnv = fakePrepareEnv("run project_name", { "GLOBAL": "g" });
26-
assert.equal(binEnv["GLOBAL"], "g");
26+
assert.strictEqual(binEnv["GLOBAL"], "g");
2727

2828
const testEnv = fakePrepareEnv("test some::mod::test_name", { "GLOBAL": "g" });
29-
assert.equal(testEnv["GLOBAL"], "g");
29+
assert.strictEqual(testEnv["GLOBAL"], "g");
3030
});
3131

3232
test('null mask works', () => {
@@ -36,10 +36,10 @@ suite('Runnable env', () => {
3636
}
3737
];
3838
const binEnv = fakePrepareEnv("run project_name", config);
39-
assert.equal(binEnv["DATA"], "data");
39+
assert.strictEqual(binEnv["DATA"], "data");
4040

4141
const testEnv = fakePrepareEnv("test some::mod::test_name", config);
42-
assert.equal(testEnv["DATA"], "data");
42+
assert.strictEqual(testEnv["DATA"], "data");
4343
});
4444

4545
test('order works', () => {
@@ -52,10 +52,10 @@ suite('Runnable env', () => {
5252
}
5353
];
5454
const binEnv = fakePrepareEnv("run project_name", config);
55-
assert.equal(binEnv["DATA"], "newdata");
55+
assert.strictEqual(binEnv["DATA"], "newdata");
5656

5757
const testEnv = fakePrepareEnv("test some::mod::test_name", config);
58-
assert.equal(testEnv["DATA"], "newdata");
58+
assert.strictEqual(testEnv["DATA"], "newdata");
5959
});
6060

6161
test('mask works', () => {
@@ -73,13 +73,13 @@ suite('Runnable env', () => {
7373
}
7474
];
7575
const binEnv = fakePrepareEnv("run project_name", config);
76-
assert.equal(binEnv["DATA"], "rundata");
76+
assert.strictEqual(binEnv["DATA"], "rundata");
7777

7878
const testEnv = fakePrepareEnv("test some::mod::test_name", config);
79-
assert.equal(testEnv["DATA"], "data");
79+
assert.strictEqual(testEnv["DATA"], "data");
8080

8181
const specialTestEnv = fakePrepareEnv("test some::mod::special_test", config);
82-
assert.equal(specialTestEnv["DATA"], "special_test");
82+
assert.strictEqual(specialTestEnv["DATA"], "special_test");
8383
});
8484

8585
test('exact test name works', () => {
@@ -93,10 +93,10 @@ suite('Runnable env', () => {
9393
}
9494
];
9595
const testEnv = fakePrepareEnv("test some::mod::test_name", config);
96-
assert.equal(testEnv["DATA"], "test special");
96+
assert.strictEqual(testEnv["DATA"], "test special");
9797

9898
const specialTestEnv = fakePrepareEnv("test some::mod::another_test", config);
99-
assert.equal(specialTestEnv["DATA"], "data");
99+
assert.strictEqual(specialTestEnv["DATA"], "data");
100100
});
101101

102102
test('test mod name works', () => {
@@ -110,10 +110,10 @@ suite('Runnable env', () => {
110110
}
111111
];
112112
const testEnv = fakePrepareEnv("test some::mod::test_name", config);
113-
assert.equal(testEnv["DATA"], "mod special");
113+
assert.strictEqual(testEnv["DATA"], "mod special");
114114

115115
const specialTestEnv = fakePrepareEnv("test some::mod::another_test", config);
116-
assert.equal(specialTestEnv["DATA"], "mod special");
116+
assert.strictEqual(specialTestEnv["DATA"], "mod special");
117117
});
118118

119119
});

0 commit comments

Comments
 (0)