Skip to content

internal: bump dashmap #19445

@davidbarsky

Description

@davidbarsky

We should bump dashmap to 7.0.0-rc2 (or whatever the latest version is) in both rust-analyzer and Salsa. This bump would allow us to remove the our dependency on hashbrown's raw API and use hashbrown::HashTable—via Dashmap—directly.

When I gave this a spin last week, the new entry API on HashTable—and, by extension—Dashmap requires some slight adjustments to [define_symbols](https://github.com/rust-lang/rust-analyzer/blob/3ed13b4a917d8028de0808a26ef14eb0abb01035/crates/intern/src/symbol/symbols.rs#L14), but I got distracted by some other stuff before I could finish.

(The 6.0.0 series has some nice performance improvements that'd be nice to take advantage of.)

Originally posted by @davidbarsky in #19430 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions