Regression: vs code test explorer skips unit tests since v0.3.2353

[soerenkoehler]

steps to reproduce:

• in VSCode install current version v0.3.2353 (bug still exists in v0.3.2370)
• in test explorer click "Run Tests"
• result:
  • test explorer / rust-analyzer seem to test dependencies instead of my code
    ra-strange-test-output.txt
  • integration tests run, but not the unit tests
    

counter check for verification:

• install v0.3.2345
• in test explorer click "Run Tests"
• result:
  • test output looks normal
    ra-correct-test-output.txt
  • tests run as expected
    

rust-analyzer version:
Identifier: rust-lang.rust-analyzer
Version: 0.3.2353
Last Updated: 2025-03-27, 21:29:57

rustc version: rustc 1.85.1 (4eb161250 2025-03-15)

editor or extension: VSCode (Win11, WSL2)
Version: 1.98.2 (user setup)
Commit: ddc367ed5c8936efe395cffeec279b04ffd7db78
Date: 2025-03-12T13:32:45.399Z
Electron: 34.2.0
ElectronBuildId: 11161602
Chromium: 132.0.6834.196
Node.js: 20.18.2
V8: 13.2.152.36-electron.0
OS: Windows_NT x64 10.0.22631

relevant settings: ---

repository link (if public, optional): https://github.com/soerenkoehler/rs-chdiff/tree/bug-test-explorer-rust-analyzer

[play-tank]

Also seeing this same issue. Same text messages as above. It appears that the code is trying to test all of the dependencies now, and not just the package.

The regression is possibly related to this:

error: unexpected argument '--custom-build' found

  tip: to pass '--custom-build' as a value, use '-- --custom-build'

I'm currently on VSCode Version: 1.99.2 (Universal), macOs Sequoia 15.3.2 (24D81)
Tried with rust-anlyzer extensions Version 0.4.2375 (Preview) and 0.3.2370 (Release)

Similar error text in the output, no results ever make it back to the test explorer.

[HKalbasi]

Potentially regressed by #19005
cc @duncanawoods

[duncanawoods]

Taking a look now

[duncanawoods]

@soerenkoehler

Thank you for the test repo. I can see that The tests are run but an error occurs updating the UI in the notification handling because the target name contains hyphens. The PR replaces with underscores and should fix that.

FYI an error can be seen in the vscode output window for the extension host:

[error] [Window] [Extension Host] Notification handler 'experimental/changeTestState' failed with message: Cannot read properties of undefined (reading 'id')

[duncanawoods]

@play-tank

trying to test all of the dependencies

This was from running tests for every package in CargoWorkspace::packages() unaware this includes dependencies. The PR filters for members only.

unexpected argument '--custom-build' found

This also included targets created by build.rs which is a custom-build target that cargo test does not support. These have also been filtered out.

[duncanawoods]

If you want to test the changes, it only affects the rust part so it's pretty easy:

1. build the PR fix

# fetch the branch
git clone -b 19464-Regression-vs-code-test-explorer-skips-unit-tests-since-v0.3.2353 git@github.com:duncanawoods/rust-analyzer.git

# build the rust binary
cd rust-analyzer/crates/rust-analyzer
cargo build -r

2. tell vscode to use your new version

Open your vscode settings as json and point rust-analyzer to wherever you have just built RA.

"rust-analyzer.server.path": "????/rust-analyzer/target/release/rust-analyzer"

3. Reload the vscode window so that the RA extension picks up the new server

[soerenkoehler]

If you want to test the changes, it only affects the rust part so it's pretty easy:
...

Today I found the time to test it. Looks good so far.