Stabilize doc_cfg feature

Author: GuillaumeGomez

compiler/rustc_ast_passes/src/feature_gate.rs

@@ -181,8 +181,6 @@ impl<'a> Visitor<'a> for PostExpansionVisitor<'a> {
 
                 gate_doc!(
                     "experimental" {
-                        cfg => doc_cfg
-                        auto_cfg => doc_cfg
                         masked => doc_masked
                         notable_trait => doc_notable_trait
                     }

compiler/rustc_error_codes/src/error_codes/E0536.md

@@ -5,7 +5,6 @@ The `not` cfg-predicate was malformed.
 Erroneous code example (using `cargo doc`):
 
 ```ignore, E0536 (only triggers on cargo doc)
-#![feature(doc_cfg)]
 #[doc(cfg(not()))]
 pub fn main() {
 
@@ -15,7 +14,6 @@ pub fn main() {
 The `not` predicate expects one cfg-pattern. Example:
 
 ```
-#![feature(doc_cfg)]
 #[doc(cfg(not(target_os = "linux")))] // ok!
 pub fn main() {
 

compiler/rustc_feature/src/accepted.rs

@@ -187,6 +187,8 @@ declare_features! (
     (accepted, do_not_recommend, "1.85.0", Some(51992)),
     /// Allows `#[doc(alias = "...")]`.
     (accepted, doc_alias, "1.48.0", Some(50146)),
+    /// Allows `#[doc(cfg(...))]`.
+    (accepted, doc_cfg, "1.21.0", Some(43781)),
     /// Allows `..` in tuple (struct) patterns.
     (accepted, dotdot_in_tuple_patterns, "1.14.0", Some(33627)),
     /// Allows `..=` in patterns (RFC 1192).

compiler/rustc_feature/src/unstable.rs

@@ -487,8 +487,6 @@ declare_features! (
     (unstable, derive_from, "1.91.0", Some(144889)),
     /// Allows giving non-const impls custom diagnostic messages if attempted to be used as const
     (unstable, diagnostic_on_const, "CURRENT_RUSTC_VERSION", Some(143874)),
-    /// Allows `#[doc(cfg(...))]`.
-    (unstable, doc_cfg, "1.21.0", Some(43781)),
     /// Allows `#[doc(masked)]`.
     (unstable, doc_masked, "1.21.0", Some(44027)),
     /// Allows features to allow target_feature to better interact with traits.

library/alloc/src/lib.rs

@@ -192,8 +192,6 @@
 #![rustc_preserve_ub_checks]
 // tidy-alphabetical-end
 //
-// Rustdoc features:
-#![feature(doc_cfg)]
 // Technically, this is a bug in rustdoc: rustdoc sees the documentation on `#[lang = slice_alloc]`
 // blocks is for `&[T]`, which also has documentation using this feature in `core`, and gets mad
 // that the feature-gate isn't enabled. Ideally, it wouldn't check for the feature gate for docs

library/core/src/lib.rs

@@ -148,7 +148,6 @@
 #![feature(deprecated_suggestion)]
 #![feature(derive_const)]
 #![feature(diagnostic_on_const)]
-#![feature(doc_cfg)]
 #![feature(doc_notable_trait)]
 #![feature(extern_types)]
 #![feature(f16)]

library/std/src/lib.rs

@@ -278,7 +278,6 @@
 #![feature(core_float_math)]
 #![feature(decl_macro)]
 #![feature(deprecated_suggestion)]
-#![feature(doc_cfg)]
 #![feature(doc_masked)]
 #![feature(doc_notable_trait)]
 #![feature(dropck_eyepatch)]

library/std_detect/src/lib.rs

@@ -15,7 +15,7 @@
 //! * `s390x`: [`is_s390x_feature_detected`]
 
 #![unstable(feature = "stdarch_internal", issue = "none")]
-#![feature(staged_api, cfg_select, doc_cfg, allow_internal_unstable)]
+#![feature(staged_api, cfg_select, allow_internal_unstable)]
 #![deny(rust_2018_idioms)]
 #![allow(clippy::shadow_reuse)]
 #![cfg_attr(test, allow(unused_imports))]

library/stdarch/crates/core_arch/src/lib.rs

@@ -17,7 +17,6 @@
     fmt_helpers_for_derive,
     rustc_attrs,
     staged_api,
-    doc_cfg,
     riscv_target_feature,
     arm_target_feature,
     mips_target_feature,

src/doc/rustdoc/src/unstable-features.md

@@ -750,271 +750,3 @@ pass `--doctest-build-arg ARG` for each argument `ARG`.
 ## `--generate-macro-expansion`: Generate macros expansion toggles in source code
 
 This flag enables the generation of toggles to expand macros in the HTML source code pages.
-
-## `#[doc(cfg)]` and `#[doc(auto_cfg)]`
-
-This feature aims at providing rustdoc users the possibility to add visual markers to the rendered documentation to know under which conditions an item is available (currently possible through the following unstable feature: `doc_cfg`).
-
-It does not aim to allow having a same item with different `cfg`s to appear more than once in the generated documentation.
-
-It does not aim to document items which are *inactive* under the current configuration (i.e., “`cfg`ed out”).
-
-This features adds the following attributes:
-
- * `#[doc(auto_cfg)]`/`#[doc(auto_cfg = true)]`/`#[doc(auto_cfg = false)]`
- * `#[doc(cfg(...))]`
- * `#![doc(auto_cfg(hide(...)))]` / `#[doc(auto_cfg(show(...)))]`
-
-All of these attributes can be added to a module or to the crate root, and they will be inherited by the child items unless another attribute overrides it. This is why "opposite" attributes like `auto_cfg(hide(...))` and `auto_cfg(show(...))` are provided: they allow a child item to override its parent.
-
-### `#[doc(cfg(...))]`
-
-This attribute provides a standardized format to override `#[cfg()]` attributes to document conditionally available items. Example:
-
-```rust,ignore (nightly)
-// the "real" cfg condition
-#[cfg(feature = "futures-io")]
-// the `doc(cfg())` so it's displayed to the readers
-#[doc(cfg(feature = "futures-io"))]
-pub mod futures {}
-```
-
-It will display in the documentation for this module:
-
-```text
-This is supported on feature="futures-io" only.
-```
-
-You can use it to display information in generated documentation, whether or not there is a `#[cfg()]` attribute:
-
-```rust,ignore (nightly)
-#[doc(cfg(feature = "futures-io"))]
-pub mod futures {}
-```
-
-It will be displayed exactly the same as the previous code.
-
-This attribute has the same syntax as conditional compilation, but it only causes documentation to be added. This means `#[doc(cfg(not(windows)))]` will not cause your docs to be hidden on non-windows targets, even though `#[cfg(not(windows))]` does do that.
-
-If `doc(auto_cfg)` is enabled on the item, `doc(cfg)` will override it anyway so in the two previous examples, even if the `doc(auto_cfg)` feature was enabled, it would still display the same thing.
-
-This attribute works on modules and on items.
-
-### `#[doc(auto_cfg(hide(...)))]`
-
-This attribute is used to prevent some `cfg` to be generated in the visual markers. It only applies to `#[doc(auto_cfg = true)]`, not to `#[doc(cfg(...))]`. So in the previous example:
-
-```rust,ignore (nightly)
-#[cfg(any(unix, feature = "futures-io"))]
-pub mod futures {}
-```
-
-It currently displays both `unix` and `feature = "futures-io"` into the documentation, which is not great. To prevent the `unix` cfg to ever be displayed, you can use this attribute at the crate root level:
-
-```rust,ignore (nightly)
-#![doc(auto_cfg(hide(unix)))]
-```
-
-Or directly on a given item/module as it covers any of the item's descendants:
-
-```rust,ignore (nightly)
-#[doc(auto_cfg(hide(unix)))]
-#[cfg(any(unix, feature = "futures-io"))]
-pub mod futures {
-    // `futures` and all its descendants won't display "unix" in their cfgs.
-}
-```
-
-Then, the `unix` cfg will never be displayed into the documentation.
-
-Rustdoc currently hides `doc` and `doctest` attributes by default and reserves the right to change the list of "hidden by default" attributes.
-
-The attribute accepts only a list of identifiers or key/value items. So you can write:
-
-```rust,ignore (nightly)
-#[doc(auto_cfg(hide(unix, doctest, feature = "something")))]
-#[doc(auto_cfg(hide()))]
-```
-
-But you cannot write:
-
-```rust,ignore (nightly)
-#[doc(auto_cfg(hide(not(unix))))]
-```
-
-So if we use `doc(auto_cfg(hide(unix)))`, it means it will hide all mentions of `unix`:
-
-```rust,ignore (nightly)
-#[cfg(unix)] // nothing displayed
-#[cfg(any(unix))] // nothing displayed
-#[cfg(any(unix, windows))] // only `windows` displayed
-```
-
-However, it only impacts the `unix` cfg, not the feature:
-
-```rust,ignore (nightly)
-#[cfg(feature = "unix")] // `feature = "unix"` is displayed
-```
-
-If `cfg_auto(show(...))` and `cfg_auto(hide(...))` are used to show/hide a same `cfg` on a same item, it'll emit an error. Example:
-
-```rust,ignore (nightly)
-#[doc(auto_cfg(hide(unix)))]
-#[doc(auto_cfg(show(unix)))] // Error!
-pub fn foo() {}
-```
-
-Using this attribute will re-enable `auto_cfg` if it was disabled at this location:
-
-```rust,ignore (nightly)
-#[doc(auto_cfg = false)] // Disabling `auto_cfg`
-pub fn foo() {}
-```
-
-And using `doc(auto_cfg)` will re-enable it:
-
-```rust,ignore (nightly)
-#[doc(auto_cfg = false)] // Disabling `auto_cfg`
-pub mod module {
-    #[doc(auto_cfg(hide(unix)))] // `auto_cfg` is re-enabled.
-    pub fn foo() {}
-}
-```
-
-However, using `doc(auto_cfg = ...)` and `doc(auto_cfg(...))` on the same item will emit an error:
-
-```rust,ignore (nightly)
-#[doc(auto_cfg = false)]
-#[doc(auto_cfg(hide(unix)))] // error
-pub fn foo() {}
-```
-
-The reason behind this is that `doc(auto_cfg = ...)` enables or disables the feature, whereas `doc(auto_cfg(...))` enables it unconditionally, making the first attribute to appear useless as it will be overidden by the next `doc(auto_cfg)` attribute.
-
-### `#[doc(auto_cfg(show(...)))]`
-
-This attribute does the opposite of `#[doc(auto_cfg(hide(...)))]`: if you used `#[doc(auto_cfg(hide(...)))]` and want to revert its effect on an item and its descendants, you can use `#[doc(auto_cfg(show(...)))]`.
-It only applies to `#[doc(auto_cfg = true)]`, not to `#[doc(cfg(...))]`.
-
-For example:
-
-```rust,ignore (nightly)
-#[doc(auto_cfg(hide(unix)))]
-#[cfg(any(unix, feature = "futures-io"))]
-pub mod futures {
-    // `futures` and all its descendants won't display "unix" in their cfgs.
-    #[doc(auto_cfg(show(unix)))]
-    pub mod child {
-        // `child` and all its descendants will display "unix" in their cfgs.
-    }
-}
-```
-
-The attribute accepts only a list of identifiers or key/value items. So you can write:
-
-```rust,ignore (nightly)
-#[doc(auto_cfg(show(unix, doctest, feature = "something")))]
-#[doc(auto_cfg(show()))]
-```
-
-But you cannot write:
-
-```rust,ignore (nightly)
-#[doc(auto_cfg(show(not(unix))))]
-```
-
-If `auto_cfg(show(...))` and `auto_cfg(hide(...))` are used to show/hide a same `cfg` on a same item, it'll emit an error. Example:
-
-```rust,ignore (nightly)
-#[doc(auto_cfg(show(unix)))]
-#[doc(auto_cfg(hide(unix)))] // Error!
-pub fn foo() {}
-```
-
-Using this attribute will re-enable `auto_cfg` if it was disabled at this location:
-
-```rust,ignore (nightly)
-#[doc(auto_cfg = false)] // Disabling `auto_cfg`
-#[doc(auto_cfg(show(unix)))] // `auto_cfg` is re-enabled.
-pub fn foo() {}
-```
-
-### `#[doc(auto_cfg)`/`#[doc(auto_cfg = true)]`/`#[doc(auto_cfg = false)]`
-
-By default, `#[doc(auto_cfg)]` is enabled at the crate-level. When it's enabled, Rustdoc will automatically display `cfg(...)` compatibility information as-if the same `#[doc(cfg(...))]` had been specified.
-
-This attribute impacts the item on which it is used and its descendants.
-
-So if we take back the previous example:
-
-```rust
-#[cfg(feature = "futures-io")]
-pub mod futures {}
-```
-
-There's no need to "duplicate" the `cfg` into a `doc(cfg())` to make Rustdoc display it.
-
-In some situations, the detailed conditional compilation rules used to implement the feature might not serve as good documentation (for example, the list of supported platforms might be very long, and it might be better to document them in one place). To turn it off, add the `#[doc(auto_cfg = false)]` attribute on the item.
-
-If no argument is specified (ie `#[doc(auto_cfg)]`), it's the same as writing `#[doc(auto_cfg = true)]`.
-
-## Inheritance
-
-Rustdoc merges `cfg` attributes from parent modules to its children. For example, in this case, the module `non_unix` will describe the entire compatibility matrix for the module, and not just its directly attached information:
-
-```rust,ignore (nightly)
-#[doc(cfg(any(windows, unix)))]
-pub mod desktop {
-    #[doc(cfg(not(unix)))]
-    pub mod non_unix {
-        // ...
-    }
-}
-```
-
-This code will display:
-
-```text
-Available on (Windows or Unix) and non-Unix only.
-```
-
-### Re-exports and inlining
-
-`cfg` attributes of a re-export are never merged with the re-exported item(s) attributes except if the re-export has the `#[doc(inline)]` attribute. In this case, the `cfg` of the re-exported item will be merged with the re-export's.
-
-When talking about "attributes merge", we mean that if the re-export has `#[cfg(unix)]` and the re-exported item has `#[cfg(feature = "foo")]`, you will only see `cfg(unix)` on the re-export and only `cfg(feature = "foo")` on the re-exported item, unless the re-export has `#[doc(inline)]`, then you will only see the re-exported item with both `cfg(unix)` and `cfg(feature = "foo")`.
-
-Example:
-
-```rust,ignore (nightly)
-#[doc(cfg(any(windows, unix)))]
-pub mod desktop {
-    #[doc(cfg(not(unix)))]
-    pub mod non_unix {
-        // code
-    }
-}
-
-#[doc(cfg(target_os = "freebsd"))]
-pub use desktop::non_unix as non_unix_desktop;
-#[doc(cfg(target_os = "macos"))]
-#[doc(inline)]
-pub use desktop::non_unix as inlined_non_unix_desktop;
-```
-
-In this example, `non_unix_desktop` will only display `cfg(target_os = "freeebsd")` and not display any `cfg` from `desktop::non_unix`.
-
-On the contrary, `inlined_non_unix_desktop` will have cfgs from both the re-export and the re-exported item.
-
-So that also means that if a crate re-exports a foreign item, unless it has `#[doc(inline)]`, the `cfg` and `doc(cfg)` attributes will not be visible:
-
-```rust,ignore (nightly)
-// dep:
-#[cfg(feature = "a")]
-pub struct S;
-
-// crate using dep:
-
-// There will be no mention of `feature = "a"` in the documentation.
-pub use dep::S as Y;
-```