rlib handling

Author: ZuseZ4

compiler/rustc_codegen_llvm/src/intrinsic.rs

@@ -21,6 +21,8 @@ use rustc_target::callconv::PassMode;
 use rustc_target::spec::Os;
 use tracing::debug;
 
+use rustc_session::config::CrateType;
+
 use crate::abi::FnAbiLlvmExt;
 use crate::builder::Builder;
 use crate::builder::autodiff::{adjust_activity_to_abi, generate_enzyme_call};
@@ -1136,8 +1138,17 @@ fn codegen_autodiff<'ll, 'tcx>(
     if !tcx.sess.opts.unstable_opts.autodiff.contains(&rustc_session::config::AutoDiff::Enable) {
         let _ = tcx.dcx().emit_almost_fatal(AutoDiffWithoutEnable);
     }
-    if tcx.sess.lto() != rustc_session::config::Lto::Fat {
-        let _ = tcx.dcx().emit_almost_fatal(AutoDiffWithoutLto);
+
+    let ct = tcx.crate_types();
+    let lto = tcx.sess.lto();
+    if ct.len() == 1 && ct.contains(&CrateType::Executable) {
+        if lto != rustc_session::config::Lto::Fat {
+            let _ = tcx.dcx().emit_almost_fatal(AutoDiffWithoutLto);
+        }
+    } else {
+        if lto != rustc_session::config::Lto::Fat && !tcx.sess.opts.cg.linker_plugin_lto.enabled(){
+            let _ = tcx.dcx().emit_almost_fatal(AutoDiffWithoutLto);
+        }
     }
 
     let fn_args = instance.args;

compiler/rustc_mir_transform/src/cross_crate_inline.rs

@@ -34,6 +34,11 @@ fn cross_crate_inlinable(tcx: TyCtxt<'_>, def_id: LocalDefId) -> bool {
         return true;
     }
 
+    // FIXME(autodiff): replace this as per discussion in https://github.com/rust-lang/rust/pull/149033#discussion_r2535465880
+    if tcx.has_attr(def_id, sym::autodiff_forward) || tcx.has_attr(def_id, sym::autodiff_reverse) || tcx.has_attr(def_id, sym::rustc_autodiff) {
+        return true;
+    }
+
     if tcx.has_attr(def_id, sym::rustc_intrinsic) {
         // Intrinsic fallback bodies are always cross-crate inlineable.
         // To ensure that the MIR inliner doesn't cluelessly try to inline fallback

compiler/rustc_monomorphize/src/collector/autodiff.rs

@@ -7,6 +7,8 @@ use crate::collector::{MonoItems, create_fn_mono_item};
 // mono so this does not interfere in `autodiff` intrinsics
 // codegen process. If they are unused, LLVM will remove them when
 // compiling with O3.
+// FIXME(autodiff): Remove this whole file, as per discussion in
+// https://github.com/rust-lang/rust/pull/149033#discussion_r2535465880
 pub(crate) fn collect_autodiff_fn<'tcx>(
     tcx: TyCtxt<'tcx>,
     instance: ty::Instance<'tcx>,

tests/ui/autodiff/autodiff_in_rlib.rs

@@ -0,0 +1,17 @@
+#![feature(autodiff)]
+#![crate_type = "rlib"]
+//@ needs-enzyme
+//@ compile-flags: -Zautodiff=Enable -C opt-level=3  -Clto=fat
+//@ build-fail
+
+// We test that we fail to compile if a user applied an autodiff_ macro in src/lib.rs,
+// since autodiff doesn't work in libraries yet. In the past we used to just return zeros in the
+// autodiffed functions, which is obviously confusing and wrong, so erroring is an improvement.
+
+use std::autodiff::autodiff_reverse;
+//~? ERROR: using the autodiff feature with library builds is not yet supported
+
+#[autodiff_reverse(d_square, Duplicated, Active)]
+pub fn square(x: &f64) -> f64 {
+    *x * *x
+}