Skip to content

Commit 570ae39

Browse files
committedSep 2, 2017
Merge branch 'master' of git://github.com/rust-lang/rust
2 parents e572d85 + 204c0a4 commit 570ae39

File tree

98 files changed

+1379
-1171
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

98 files changed

+1379
-1171
lines changed
 

‎.gitmodules

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,3 +33,6 @@
3333
[submodule "src/libcompiler_builtins"]
3434
path = src/libcompiler_builtins
3535
url = https://github.com/rust-lang-nursery/compiler-builtins
36+
[submodule "src/tools/clippy"]
37+
path = src/tools/clippy
38+
url = https://github.com/rust-lang-nursery/rust-clippy.git

‎CONTRIBUTING.md

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -298,6 +298,32 @@ Speaking of tests, Rust has a comprehensive test suite. More information about
298298
it can be found
299299
[here](https://github.com/rust-lang/rust-wiki-backup/blob/master/Note-testsuite.md).
300300

301+
### External Dependencies
302+
303+
Currently building Rust will also build the following external projects:
304+
305+
* [clippy](https://github.com/rust-lang-nursery/rust-clippy)
306+
307+
If your changes break one of these projects, you need to fix them by opening
308+
a pull request against the broken project. When you have opened a pull request,
309+
you can point the submodule at your pull request by calling
310+
311+
```
312+
git fetch origin pull/$id_of_your_pr/head:my_pr
313+
git checkout my_pr
314+
```
315+
316+
within the submodule's directory. Don't forget to also add your changes with
317+
318+
```
319+
git add path/to/submodule
320+
```
321+
322+
outside the submodule.
323+
324+
It can also be more convenient during development to set `submodules = false`
325+
in the `config.toml` to prevent `x.py` from resetting to the original branch.
326+
301327
## Writing Documentation
302328

303329
Documentation improvements are very welcome. The source of `doc.rust-lang.org`

0 commit comments

Comments
 (0)