Unrolled build for #150548

Rollup merge of #150548 - dianne:temp-scope-extension-loop-rewrite, r=BoxyUwU

`region_scope_tree`: Rewrite a `loop` as tail recursion

This addresses #146098 (comment), hopefully making `record_subexpr_extended_temp_scopes` a bit more legible.

I removed a `debug!` in the process, since the function it calls every iteration, [`ScopeTree::record_extended_temp_scope`](https://github.com/rust-lang/rust/blob/2848c2ebe9a8a604cd63455263299d7258bc8252/compiler/rustc_middle/src/middle/region.rs#L264-L271), does the same `debug!`. Keeping the behavior of having an additional `debug!` for the top-level expression would hurt legibility, and having a duplicate `debug!` at each iteration seems excessive. No information is lost from the debug output, so I think it's fine to just have the inner `debug!`s.

r? BoxyUwU or anyone

Author: rust-timer

compiler/rustc_hir_analysis/src/check/region.rs

@@ -701,31 +701,25 @@ fn resolve_local<'tcx>(
 /// Note: ET is intended to match "rvalues or places based on rvalues".
 fn record_subexpr_extended_temp_scopes(
     scope_tree: &mut ScopeTree,
-    mut expr: &hir::Expr<'_>,
+    expr: &hir::Expr<'_>,
     lifetime: Option<Scope>,
 ) {
-    debug!(?expr, ?lifetime);
+    // Note: give all the expressions matching `ET` with the
+    // extended temporary lifetime, not just the innermost rvalue,
+    // because in MIR building if we must compile e.g., `*rvalue()`
+    // into a temporary, we request the temporary scope of the
+    // outer expression.
 
-    loop {
-        // Note: give all the expressions matching `ET` with the
-        // extended temporary lifetime, not just the innermost rvalue,
-        // because in MIR building if we must compile e.g., `*rvalue()`
-        // into a temporary, we request the temporary scope of the
-        // outer expression.
+    scope_tree.record_extended_temp_scope(expr.hir_id.local_id, lifetime);
 
-        scope_tree.record_extended_temp_scope(expr.hir_id.local_id, lifetime);
-
-        match expr.kind {
-            hir::ExprKind::AddrOf(_, _, subexpr)
-            | hir::ExprKind::Unary(hir::UnOp::Deref, subexpr)
-            | hir::ExprKind::Field(subexpr, _)
-            | hir::ExprKind::Index(subexpr, _, _) => {
-                expr = subexpr;
-            }
-            _ => {
-                return;
-            }
+    match expr.kind {
+        hir::ExprKind::AddrOf(_, _, subexpr)
+        | hir::ExprKind::Unary(hir::UnOp::Deref, subexpr)
+        | hir::ExprKind::Field(subexpr, _)
+        | hir::ExprKind::Index(subexpr, _, _) => {
+            record_subexpr_extended_temp_scopes(scope_tree, subexpr, lifetime);
         }
+        _ => {}
     }
 }