Skip to content

Tracking Issue for Never Patterns (never_patterns) #118155

Open
@Nadrieril

Description

@Nadrieril
Member

This is a tracking issue for the experimental "never patterns" feature (as per the T-lang experimental feature process).
The feature gate for the issue is #![feature(never_patterns)].

RFC: rust-lang/rfcs#3719

This feature introduces a new syntax for patterns: !. In a pattern, ! is valid for any uninhabited type and simply acknowledges that the type is empty. Because a never pattern is statically known to be unreachable, it obeys slightly different rules:

enum Void {}
let result: *const Result<u32, Void> = ...;
unsafe {
    match *result {
        Ok(x) => { foo(x) }
        Err(!), // no need for `=> <expr>`
    }
    let (Ok(x) | Err(!)) = *result; // valid
}

fn blah(!: Void) -> SomeType {} // the function can never be called so it doesn't need a body

This feature does not affect exhaustiveness or pattern reachability; see the exhaustive_patterns and min_exhaustive_patterns features for that.

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

Unresolved Questions

### Implementation plans/details
- [x] `!` is parsed as a pattern.
- [x] Parsing of `match` expressions allows `match <expr> { <pat>, ... }` i.e. a pattern without a body. We later check to only allow that if the pattern is a never pattern.
- [ ] The lack of body is desugared into something equivalent to `unreachable_unchecked!()`.
- [x] Never patterns skip the or-pattern bindings check, to allow `Ok(x) | Err(!)`
- [x] Never patterns don't allow bindings, like in `(x, !)`
- [x] Allow `fn foo(!: Void) -> SomeType {}`
- [x] `!` is typechecked like a wildcard; it adds no type constraint
- [x] In match checking we check that `!` is only used on an uninhabited type (modulo match ergonomics).
- [ ] The `!` pattern is lowered to MIR.
- [ ] A `!` pattern asserts validiy of the matched place
- [x] Exhaustiveness understands `!`.
- [x] Exhaustiveness recommends using never patterns where sensible.
- [ ] Rustfmt understands never patterns
- [ ] Check every bit of the compiler that handles or-patterns to see if it handles never patterns properly
- [x] Write up the RFC
- [ ] https://github.com/rust-lang/rust/issues/120240
### Implementation history
- [ ] https://github.com/rust-lang/rust/pull/118157
- [ ] #118527
- [ ] https://github.com/rust-lang/rust/pull/118868
- [ ] https://github.com/rust-lang/rust/pull/119610
- [ ] https://github.com/rust-lang/rust/pull/119622
- [ ] https://github.com/rust-lang/rust/pull/120009
- [ ] https://github.com/rust-lang/rust/pull/120097
- [ ] https://github.com/rust-lang/rust/pull/120104
- [ ] https://github.com/rust-lang/rust/pull/120517
- [ ] https://github.com/rust-lang/rust/pull/120758
- [ ] https://github.com/rust-lang/rust/pull/121391
- [ ] https://github.com/rust-lang/rust/pull/121823
- [ ] https://github.com/rust-lang/rust/pull/123332

Activity

added
T-langRelevant to the language team
C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFC
A-exhaustiveness-checkingRelating to exhaustiveness / usefulness checking of patterns
on Nov 22, 2023
RalfJung

RalfJung commented on Nov 22, 2023

@RalfJung
changed the title [-]Tracking Issue for Never Patterns[/-] [+]Tracking Issue for Never Patterns (never_patterns)[/+] on Nov 22, 2023
Nadrieril

Nadrieril commented on Nov 22, 2023

@Nadrieril
Author
added a commit that references this issue on Nov 26, 2023

Auto merge of rust-lang#118308 - Nadrieril:sound-exhaustive-patterns-…

added 3 commits that reference this issue on Nov 29, 2023

Rollup merge of rust-lang#118157 - Nadrieril:never_pat-feature-gate, …

da1f9d4

Rollup merge of rust-lang#118157 - Nadrieril:never_pat-feature-gate, …

4915a5e

Rollup merge of rust-lang#118157 - Nadrieril:never_pat-feature-gate, …

c03f891
added a commit that references this issue on Nov 29, 2023

62 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-exhaustiveness-checkingRelating to exhaustiveness / usefulness checking of patternsB-experimentalBlocker: In-tree experiment; RFC pending, not yet approved or unneeded (requires FCP to stabilize).B-unstableBlocker: Implemented in the nightly compiler and unstable.C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCF-never_patterns`#![feature(never_patterns)]`S-tracking-impl-incompleteStatus: The implementation is incomplete.T-langRelevant to the language team

    Type

    No type

    Projects

    Status

    Exploration

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @joshtriplett@RalfJung@compiler-errors@dead-claudia@Nadrieril

        Issue actions

          Tracking Issue for Never Patterns (`never_patterns`) · Issue #118155 · rust-lang/rust