-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
A-incr-compArea: Incremental compilationArea: Incremental compilationA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.Category: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
Currently rustc_expected_cgu_reuse
is in practice ignored. These tests use that attribute:
- tests/incremental/thinlto/cgu_invalidated_via_import.rs
- tests/incremental/thinlto/cgu_keeps_identical_fn.rs
- tests/incremental/thinlto/independent_cgus_dont_affect_each_other.rs
Step-by-step
- Change the value of
kind
field of anyrustc_expected_cgu_reuse
attribute in any test that usesrustc_expected_cgu_reuse
. - Run the test, e.g. with
./x test tests/incremental/thinlto
Expected
Test fails since we changed the expected outcome
Actual
Test pass, because rustc_expected_cgu_reuse
is in practice ignored.
Example:
This PR should have failed CI but it didn't: #118971
How to fix
Here is a PR with a fix: #118973
michaelwoerister
Metadata
Metadata
Assignees
Labels
A-incr-compArea: Incremental compilationArea: Incremental compilationA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.Category: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.