-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed as not planned
Labels
T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-cargoRelevant to the cargo team, which will review and decide on the PR/issue.Relevant to the cargo team, which will review and decide on the PR/issue.
Description
Run
x.py build
x.py dist
And x.py dist
will rebuild cargo for no good reason (the rebuilt cargo executable is unchanged at all). Using a cargo instrumented with debug output:
the rustflags changed from
["-C", "target-cpu=raptorlake", "--cfg=windows_raw_dylib", "-Csymbol-mangling-version=v0", "-Zunstable-options", "--check-cfg=cfg(bootstrap)", "--check-cfg=cfg(parallel_compiler)", "--check-cfg=cfg(rust_analyzer)", "-Zmacro-backtrace", "-Csplit-debuginfo=off", "-Clink-args=-Wl,-z,origin", "-Clink-args=-Wl,-rpath,$ORIGIN/../lib", "-Zunstable-options"] to
["-C", "target-cpu=raptorlake", "--cfg=windows_raw_dylib", "-Csymbol-mangling-version=v0", "-Zunstable-options", "--check-cfg=cfg(bootstrap)", "--check-cfg=cfg(parallel_compiler)", "--check-cfg=cfg(rust_analyzer)", "-Zmacro-backtrace", "-Csplit-debuginfo=off", "-Clink-args=-Wl,-z,origin", "-Clink-args=-Wl,-rpath,$ORIGIN/../lib", "-Zunstable-options", "-Zon-broken-pipe=kill"]
AFAIK -Zon-broken-pipe=kill
shouldn't affect code generation, thus there's no need to rebuild cargo.
Metadata
Metadata
Assignees
Labels
T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-cargoRelevant to the cargo team, which will review and decide on the PR/issue.Relevant to the cargo team, which will review and decide on the PR/issue.