-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Closed
Closed
Copy link
Labels
A-run-makeArea: port run-make Makefiles to rmake.rsArea: port run-make Makefiles to rmake.rsA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCCategory: An issue tracking the progress of sth. like the implementation of an RFCT-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
Three rmake.rs
use unstable
features that cannot be used (because they need to be build by the stage0 compiler which usually is not a nightly compiler), and needs to be fixed (this was a bug in the previous infra implementation and partially rectified in #137373):
-
tests/run-make/issue-107495-archive-permissions/rmake.rs
:#![feature(rustc_private)] -
tests/run-make/cross-lang-lto/rmake.rs
:#![feature(path_file_prefix)] -
tests/run-make/broken-pipe-no-ice/rmake.rs
:#![feature(anonymous_pipe)]
After these tests are fixed and #137373 merges, we need to:
- Build
rmake.rs
withRUSTC_BOOTSTRAP=-1
to prevent any nightly feature usages withinrmake.rs
recipes by convincing the stage 0 compiler used to buildrmake.rs
that it is a stable-channel compiler. Preventrmake.rs
from using unstable features, and fix 3 run-make tests that currently do #137537 - Explicitly document this requirement in rustc-dev-guide. Prevent
rmake.rs
from using unstable features, and fix 3 run-make tests that currently do #137537
FIXME
- Replace
os_pipe
withanonymous_pipe
once it stabilizes and reaches beta. cf. Stabilizeanonymous_pipe
#135822 or Stablize anonymous pipe #137793.
Metadata
Metadata
Assignees
Labels
A-run-makeArea: port run-make Makefiles to rmake.rsArea: port run-make Makefiles to rmake.rsA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCCategory: An issue tracking the progress of sth. like the implementation of an RFCT-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.