Skip to content

Add a tidy check to enforce that all compiler/*/Cargo.tomlcontains lints.workspace = true #138195

Not planned
@jieyouxu

Description

@jieyouxu
Member

To consistently enforce lints across all compiler/ crates after #138084.

I.e. check that all compiler crates have

[lints]
workspace = true

see #138084 (comment) #138084 (comment).

See also #138106; note that this is only applicable for non-tool lints (i.e. not for rustc::xxx internal tool lints).

Activity

added
A-lintsArea: Lints (warnings about flaws in source code) such as unused_mut.
A-tidyArea: The tidy tool
C-enhancementCategory: An issue proposing an enhancement or a PR with one.
T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
on Mar 8, 2025
added
needs-triageThis issue may need triage. Remove it if it has been sufficiently triaged.
on Mar 8, 2025
removed
needs-triageThis issue may need triage. Remove it if it has been sufficiently triaged.
on Mar 8, 2025
self-assigned this
on Mar 8, 2025
jieyouxu

jieyouxu commented on Mar 11, 2025

@jieyouxu
MemberAuthor

Actually, closing this as stale since we probably can't go the workspace lint approach due to root manifest not being in rustc-src problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-lintsArea: Lints (warnings about flaws in source code) such as unused_mut.A-tidyArea: The tidy toolC-enhancementCategory: An issue proposing an enhancement or a PR with one.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @nnethercote@jieyouxu@rustbot

    Issue actions

      Add a tidy check to enforce that all `compiler/*/Cargo.toml`contains `lints.workspace = true` · Issue #138195 · rust-lang/rust