"./x.py test --verbose --no-fail-fast" causes tidy to fail

[Zeckmathederg]

With node.js-22.20.0 (npm-10.9.3) installed, a test checking if /usr/bin/npm --verbose returns exit code 0 fails. This is because npm's behavior when not given a command will return exit code 1. As far as npm is concerned, it wasn't given a command, like help, even though the --verbose option was passed. However, passing help to the npm command will return exit code 0 as intended. So the command to run would be /usr/bin/npm --verbose help. This should make the test succeed.

The file seeming to cause it is src/bootstrap/src/core/build_steps/test.rs.

[chenyukang]

which command fail, x test tidy or some other commands?

rust/src/bootstrap/src/core/build_steps/test.rs

Line 1230 in b6f0945

cmd.arg("npm");

this line only pass the npm args into rust-tidy program, and I guess finally run here:

https://github.com/chenyukang/rust/blob/53c79f4523b228cf04a772dc474ac9315b456f7f/src/tools/tidy/src/extra_checks/mod.rs#L326-L343

[lolbinarycat]

Please clarify what command was run to cause this error.

[renodr]

I can reproduce this with "./x.py test --verbose --no-fail-fast"

On my end it generates the following error:

1 command(s) did not execute successfully:

Command LD_LIBRARY_PATH="/sources/rustc-1.90.0-src/rustc-1.90.0-src/build/x86_64-unknown-linux-gnu/bootstrap-tools/x86_64-unknown-linux-gnu/release/deps" RUSTC="/sources/rustc-1.90.0-src/rustc-1.90.0-src/build/x86_64-unknown-linux-gnu/stage0/bin/rustc" "/sources/rustc-1.90.0-src/rustc-1.90.0-src/build/x86_64-unknown-linux-gnu/stage0-tools-bin/rust-tidy" "/sources/rustc-1.90.0-src/rustc-1.90.0-src" "/sources/rustc-1.90.0-src/rustc-1.90.0-src/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "/sources/rustc-1.90.0-src/rustc-1.90.0-src/build" "32" "/usr/bin/npm" "--verbose" (failure_mode=DelayFail) did not execute successfully.
Expected success, got exit status: 1
Created at: src/bootstrap/src/core/build_steps/tool.rs:1529:23
Executed at: src/bootstrap/src/core/build_steps/test.rs:1187:29

Traceback (most recent call last):
File "/sources/rustc-1.90.0-src/rustc-1.90.0-src/./x.py", line 53, in
bootstrap.main()
~~~~~~~~~~~~~~^^
File "/sources/rustc-1.90.0-src/rustc-1.90.0-src/src/bootstrap/bootstrap.py", line 1377, in main
bootstrap(args)
~~~~~~~~~^^^^^^
File "/sources/rustc-1.90.0-src/rustc-1.90.0-src/src/bootstrap/bootstrap.py", line 1352, in bootstrap
run(args, env=env, verbose=build.verbose, is_bootstrap=True)
~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/sources/rustc-1.90.0-src/rustc-1.90.0-src/src/bootstrap/bootstrap.py", line 237, in run
raise RuntimeError(err)
RuntimeError: failed to run: /sources/rustc-1.90.0-src/rustc-1.90.0-src/build/bootstrap/debug/bootstrap test --verbose --no-fail-fast

The distro is Linux From Scratch version 12.4-systemd, building with the development instructions at https://linuxfromscratch.org/blfs/view/systemd/general/rust.html

[lolbinarycat]

Yeah, that command is not running npm, that is running tidy and passing "npm" as the path to npm. Please provide the full terminal output inside a <details> tag.

[lolbinarycat]

Ran this locally (with newer software versions installed) and I get the same error.

If I had to guess what's going on I would say that it's an issue with the --no-fail-fast logic, where an earlier test fails (probably in ui-fulldeps), and this somehow causes a cascading failure that makes tidy fail.