-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Open
Labels
A-a11yArea: Anything to do with accessibilityArea: Anything to do with accessibilityC-bugCategory: This is a bug.Category: This is a bug.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.
Description
Background links: https://www.w3.org/TR/WCAG20-TECHS/H32.html for a11y, http://doc.rust-lang.org/std/ for rustdoc search. Before typing anything:
After typing a query:
Basically, we currently implement the searchbox by using JS to hook into the submission: https://github.com/rust-lang/rust/blob/master/src/librustdoc/html/static/main.js#L737-L741
So we're not providing a 'submit' button. But we're supposed to.
I'm not sure of the best way to resolve this, exactly. I think the plan would be:
- create an
<input type="submit">
- hide it with CSS
- have it trigger that JS instead
Does that make sense? I am bad at front-end :(
Metadata
Metadata
Assignees
Labels
A-a11yArea: Anything to do with accessibilityArea: Anything to do with accessibilityC-bugCategory: This is a bug.Category: This is a bug.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.