-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
B-RFC-approvedBlocker: Approved by a merged RFC but not yet implemented.Blocker: Approved by a merged RFC but not yet implemented.B-unstableBlocker: Implemented in the nightly compiler and unstable.Blocker: Implemented in the nightly compiler and unstable.C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCCategory: An issue tracking the progress of sth. like the implementation of an RFCE-needs-testCall for participation: An issue has been fixed and does not reproduce, but no test has been added.Call for participation: An issue has been fixed and does not reproduce, but no test has been added.T-langRelevant to the language teamRelevant to the language team
Description
Tracking issue for rust-lang/rfcs#1358
cubuspl42, briansmith, tjkirch, ruuda, timvisee and 2 more
Metadata
Metadata
Assignees
Labels
B-RFC-approvedBlocker: Approved by a merged RFC but not yet implemented.Blocker: Approved by a merged RFC but not yet implemented.B-unstableBlocker: Implemented in the nightly compiler and unstable.Blocker: Implemented in the nightly compiler and unstable.C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCCategory: An issue tracking the progress of sth. like the implementation of an RFCE-needs-testCall for participation: An issue has been fixed and does not reproduce, but no test has been added.Call for participation: An issue has been fixed and does not reproduce, but no test has been added.T-langRelevant to the language teamRelevant to the language team
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
kennytm commentedon Jun 28, 2016
heap::EMPTY
is currently defined as1
and is used as the address of reference to zero-sized types. Would it affect the program's correctness if we change the alignment of a ZST?cc #27700.
retep998 commentedon Jun 28, 2016
@kennytm That already is an issue without this RFC.
kennytm commentedon Jun 28, 2016
@retep998 Okay thanks. So it is entirely an issue of #27700.
whitequark commentedon Oct 5, 2016
Anyone else implementing this? I need it so I may give it a go.
mfarrugi commentedon Nov 17, 2016
What's the relationship of this issue to simd support #27731 (ie. the current way to accomplish this on nightly)?
Can/should this be implemented separately?
lu-zero commentedon Jan 5, 2017
@mfarrugi the two are related but not that much. SIMD usually works better on aligned data, but you need aligned data also when you use other kind of hardware features (dma engines for crypto, video decoding/encoding, etc). @whitequark got time to implement it? From what I can see the allocator now is taking an alignment so it should be not terrible to implement (I do not know the rust internals well enough to be confident in poking around this).
whitequark commentedon Jan 6, 2017
@lu-zero Ok let me give it another try. Rustbuild and (hopefully?) incremental compilation have made rustc hacking much less painful...
bitshifter commentedon Jan 14, 2017
@whitequark have started on this? I was interested and got a proof of concept working, so if you haven't started on it I could probably finish off what I'm doing and make a PR. I'd probably need some mentoring from someone, I haven't added a feature before.
whitequark commentedon Jan 14, 2017
@bitshifter not really, please go ahead!
117 remaining items