-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.Relevant to the infrastructure team, which will review and decide on the PR/issue.
Description
Currently, the integration of the libc crate is very very hacky.
- Its integrated as git submodule, and not as cargo dependency.
- It is used via a shim (
src/rustc/libc_shim
) for the sole purpose of passing a cfg flagstdbuild
to the crate.
I propose we revive the rustbuild
feature that has been removed by #42495 and:
- Use libc from crates.io, without a shim, and removing the submodule
- Either use cargo features, or revive the
rustbuild
cfg flag removed by Bump to 1.20.0 and update stage0 compiler #42495 and use it instead ofstdbuild
kennytm
Metadata
Metadata
Assignees
Labels
T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.Relevant to the infrastructure team, which will review and decide on the PR/issue.