Skip to content

Rust 1.26.1 point release #50756

Closed
Closed
@pietroalbini

Description

@pietroalbini
Member

Note: there is no decision on whether 1.26.1 should be released yet. This is just a wishlist.

There are a few bad bugs in the 1.26.0 release, and there is a discussion (#50646 (comment)) about making a point release with a few backports. This issue tracks the PRs we would like to backport, and if we should do the point release at all.

cc @rust-lang/release @rust-lang/core


Activity

added
T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.
on May 14, 2018
added
T-coreRelevant to the core team, which will review and decide on the PR/issue.
C-feature-requestCategory: A feature request, i.e: not implemented / a PR.
on May 14, 2018
leoyvens

leoyvens commented on May 14, 2018

@leoyvens
Contributor

I'd like to propose #50694 for an eventual point release, it makes impl Trait work with a bunch of common traits that have a Self default (impl PartialEq, impl Add, ...) rather than stack overflow.

BatmanAoD

BatmanAoD commented on May 14, 2018

@BatmanAoD
Member

It sounds like #50646 has already been fixed in the beta channel. Does the backport require a new PR?

sanxiyn

sanxiyn commented on May 15, 2018

@sanxiyn
Member

#49462 affects ARM as well as FreeBSD. I think the point release is warranted.

smmalis37

smmalis37 commented on May 15, 2018

@smmalis37
Contributor

I'd like to strongly vote in favor of a point release containing the fix for #50646.

est31

est31 commented on May 15, 2018

@est31
Member

We should also backport #49523. Right now the distributed source of the 1.26.0 release artifacts don't contain release notes for the 1.26.0 release, which is bad.

nrc

nrc commented on May 15, 2018

@nrc
Member

We're getting quite a lot of reports of problems on the RLS repo, so I'd be in favour of a point release for the RLS. I'll put together a PR.

I'd also like to update rustfmt due to rust-lang/rustfmt#2695

nrc

nrc commented on May 16, 2018

@nrc
Member

PR for RLS/Rustfmt: #50794

kennytm

kennytm commented on May 16, 2018

@kennytm
Member

I nominate #50811 to be included.

13 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-feature-requestCategory: A feature request, i.e: not implemented / a PR.T-coreRelevant to the core team, which will review and decide on the PR/issue.T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @sanxiyn@kennytm@nrc@pietroalbini@BatmanAoD

        Issue actions

          Rust 1.26.1 point release · Issue #50756 · rust-lang/rust