Closed
Description
Note: there is no decision on whether 1.26.1 should be released yet. This is just a wishlist.
There are a few bad bugs in the 1.26.0 release, and there is a discussion (#50646 (comment)) about making a point release with a few backports. This issue tracks the PRs we would like to backport, and if we should do the point release at all.
cc @rust-lang/release @rust-lang/core
- Filter out missing components from manifests #49705: Filter out missing components from manifests
- Reason: rustup can't download 1.26.0 on both ARM and FreeBSD (tier 2 platform) rustup update fails on FreeBSD for nightly due to missing docs #49462
- Fix
fn main() -> impl Trait
for non-Termination
trait #50656: Fixfn main() -> impl Trait
for non-Termination
trait- Reason: that syntax was stabilized by accident impl Trait is allowed in the return type of main #50595
- Update stable channel RLS and Rustfmt #50794
- Reason: RLS doesn't work on Windows RLS interferring with compilation after 1.26 #50646
- Update stable channel RLS and Rustfmt #50794 (same as RLS)
- Reason: rustfmt badly formats things Unexpected string literal indents rustfmt#2695
- n/a
- Reason: missing 1.26.0 release notes (Update RELEASES.md for 1.26.0 #49523) on the stable artifacts
- Fix issue #50811 (
NaN > NaN
was true). #50812:NaN > NaN
- Reason: Fixes bug in const-eval
Metadata
Metadata
Assignees
Labels
Type
Projects
Milestone
Relationships
Development
No branches or pull requests
Activity
leoyvens commentedon May 14, 2018
I'd like to propose #50694 for an eventual point release, it makes
impl Trait
work with a bunch of common traits that have aSelf
default (impl PartialEq
,impl Add
, ...) rather than stack overflow.BatmanAoD commentedon May 14, 2018
It sounds like #50646 has already been fixed in the beta channel. Does the backport require a new PR?
sanxiyn commentedon May 15, 2018
#49462 affects ARM as well as FreeBSD. I think the point release is warranted.
smmalis37 commentedon May 15, 2018
I'd like to strongly vote in favor of a point release containing the fix for #50646.
est31 commentedon May 15, 2018
We should also backport #49523. Right now the distributed source of the 1.26.0 release artifacts don't contain release notes for the 1.26.0 release, which is bad.
nrc commentedon May 15, 2018
We're getting quite a lot of reports of problems on the RLS repo, so I'd be in favour of a point release for the RLS. I'll put together a PR.
I'd also like to update rustfmt due to rust-lang/rustfmt#2695
nrc commentedon May 16, 2018
PR for RLS/Rustfmt: #50794
kennytm commentedon May 16, 2018
I nominate #50811 to be included.
13 remaining items