Skip to content

Fix rustdoc-js unit-test for substring after removal of unstable API #58331

@Matthias247

Description

@Matthias247
Contributor

As discovered in #57992, the test in https://github.com/rust-lang/rust/blob/master/src/test/rustdoc-js/substring.js referenced an API unstable, which lead to a breaking test when the API was removed.

Per discussion with @GuillaumeGomez I am removing the test inside #57992 in order to unblock that change. The test should be fixed afterwards. Ideally without referencing unstable APIs.

Activity

added
A-testsuiteArea: The testsuite used to check the correctness of rustc
T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
on Feb 9, 2019
GuillaumeGomez

GuillaumeGomez commented on Feb 9, 2019

@GuillaumeGomez
Member

The simplest way to fix this issue is to make the substring search outside of the std libs. It'll be easier when #58330 will get merged.

added a commit that references this issue on Apr 11, 2019
b9a99b9
added a commit that references this issue on Apr 12, 2019
d77b7d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcT-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @jonas-schievink@GuillaumeGomez@Matthias247

    Issue actions

      Fix rustdoc-js unit-test for substring after removal of unstable API · Issue #58331 · rust-lang/rust