-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcT-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.
Description
As discovered in #57992, the test in https://github.com/rust-lang/rust/blob/master/src/test/rustdoc-js/substring.js referenced an API unstable, which lead to a breaking test when the API was removed.
Per discussion with @GuillaumeGomez I am removing the test inside #57992 in order to unblock that change. The test should be fixed afterwards. Ideally without referencing unstable APIs.
Metadata
Metadata
Assignees
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcT-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
GuillaumeGomez commentedon Feb 9, 2019
The simplest way to fix this issue is to make the substring search outside of the std libs. It'll be easier when #58330 will get merged.
Rollup merge of rust-lang#59711 - GuillaumeGomez:substring-test, r=Qu…
Rollup merge of rust-lang#59711 - GuillaumeGomez:substring-test, r=Qu…