Skip to content

The push_* printing in librustc_monomorphize should use the printing infrastructure #60582

Closed
@varkor

Description

@varkor
Member

E.g. push_const_name here:

pub fn push_const_name(&self, c: &Const<'tcx>, output: &mut String, debug: bool) {

See #53645 (comment).

Activity

added
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.
A-const-genericsArea: const generics (parameters and arguments)
on May 6, 2019
added
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
on May 6, 2019
eddyb

eddyb commented on May 6, 2019

@eddyb
Member

I didn't mean const printing, sorry. But rather that entire push_* stuff, which was hacked together for the monomorphization collector but can now use the printing infrastructure.

removed
A-const-genericsArea: const generics (parameters and arguments)
on May 11, 2019
changed the title [-]Use `ty::print` infrastructure for const printing[/-] [+]The `push_*` printing in `librustc_monomorphize` should use the printing infrastructure[/+] on May 11, 2019
Mark-Simulacrum

Mark-Simulacrum commented on Jun 22, 2019

@Mark-Simulacrum
Member

This code now lives in https://github.com/rust-lang/rust/blob/929b48ec98aaff2239257574b5897f419cec2647/src/librustc/ty/print/obsolete.rs as far as I can tell, so this is probably a duplicate of #61139 at this point. Closing as such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-cleanupCategory: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @eddyb@jonas-schievink@varkor@Mark-Simulacrum

        Issue actions

          The `push_*` printing in `librustc_monomorphize` should use the printing infrastructure · Issue #60582 · rust-lang/rust