Skip to content

rustc should use vendor names for target features #61895

Closed
@newpavlov

Description

@newpavlov
Contributor

Right now in source code we follow vendor names and not LLVM ones (e.g. rdrand and not rdrnd). Translation is handled here. But when enabling target feature via rustc flags we have to use LLVM names, i.e. -C target-feature=+rdrnd and +rdrand will not work. So we have inconsistency on our hands.

At the very least vendor names provided in rustc flags should be translated to LLVM ones. Additionally I think we should not expose LLVM names at all, including in rustc --print target-features.

Relevant: #50077, #48369

Activity

added
A-driverArea: rustc_driver that ties everything together into the `rustc` compiler
C-enhancementCategory: An issue proposing an enhancement or a PR with one.
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
on Jun 16, 2019
hanna-kruppe

hanna-kruppe commented on Jun 16, 2019

@hanna-kruppe
Contributor

cf. #49653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-driverArea: rustc_driver that ties everything together into the `rustc` compilerC-enhancementCategory: An issue proposing an enhancement or a PR with one.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @newpavlov@jonas-schievink@hanna-kruppe

        Issue actions

          rustc should use vendor names for target features · Issue #61895 · rust-lang/rust