Skip to content

core doc-tests don't run #62218

Closed
Closed
@cuviper

Description

@cuviper
Member

I'm adding something to Iterator, and I wanted to try my examples, but I can't seem to get any doc tests to run for core.

$ ./x.py test --doc libcore
[...]
Building rustdoc for stage1 (x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.07s
Testing core stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
    Finished release [optimized] target(s) in 0.07s
   Doc-tests core

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

Same for ./x.py test --doc src/libcore.

If I remove the --doc parameter, it does run unit tests, but still 0 doc tests.

I'm suspicious of this comment:

rust/src/libcore/lib.rs

Lines 50 to 51 in 3849a5f

// This cfg won't affect doc tests.
#![cfg(not(test))]

Activity

cuviper

cuviper commented on Jun 28, 2019

@cuviper
MemberAuthor

I guess #62213 and #61199 are meant to address this?

added
A-doctestsArea: Documentation tests, run by rustdoc
C-bugCategory: This is a bug.
T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.
T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
on Jun 28, 2019
jonas-schievink

jonas-schievink commented on Jun 28, 2019

@jonas-schievink
Contributor

I guess #62213 and #61199 are meant to address this?

Correct

QuietMisdreavus

QuietMisdreavus commented on Jun 30, 2019

@QuietMisdreavus
Member

Now that #61199 has landed, this should be fixed.

ollie27

ollie27 commented on Jul 1, 2019

@ollie27
Member

Yeah, I've checked the recent build logs on azure and the core doctests are now being run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-doctestsArea: Documentation tests, run by rustdocC-bugCategory: This is a bug.T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @cuviper@jonas-schievink@QuietMisdreavus@ollie27

        Issue actions

          core doc-tests don't run · Issue #62218 · rust-lang/rust