Closed
Description
Hello, this is your friendly neighborhood mergebot.
After merging PR #62335, I observed that the tool miri has failing tests.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.
cc @Mark-Simulacrum, do you think you would have time to do the follow-up work?
If so, that would be great!
cc @Mark-Simulacrum, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.
Activity
Mark-Simulacrum commentedon Jul 3, 2019
from https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_apis/build/builds/2278/logs/929
RalfJung commentedon Jul 3, 2019
Looks like a bunch of tests are affected the same way:
RalfJung commentedon Jul 3, 2019
Cc @christianpoveda this is likely caused by your change, somehow.
RalfJung commentedon Jul 3, 2019
Likely caused by a missing
force_ptr
in function pointer validation. Should be fixed by #62245.pvdrz commentedon Jul 4, 2019
I merged @RalfJung's branches with my branches in both the rust and miri repos and all the tests passed :D
miri
no longer builds after rust-lang/rust#62355 #62362pnkfelix commentedon Jul 4, 2019
triage: P-medium, removing nomination,
assigningalready assigned to @RalfJung11 remaining items