Skip to content

Extend bindings_after_at (b1 @ Some(b2)) tests with nested or_patterns #67311

Closed
@Centril

Description

@Centril
Contributor

Once #![feature(or_patterns)] (#54883), i.e. pat_0 | ... | pat_n in nested positions, e.g. Some(Ok(a) | Err(b)) have progressed sufficiently in their implementation, e.g. when the MIR building implementation is done, we should extend the test suite for #![feature(bindings_after_at)] (#65490), e.g. b1 @ Some(b2), to exercise the combination of these two features. Ideally, we would also account for the combination of those two with #![feature(slice_patterns)] (#62254) and #![feature(box_patterns)] (#29641) as well to make things really air-tight.

This issue has been assigned to @thekuom via this comment.

Activity

added
E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
A-testsuiteArea: The testsuite used to check the correctness of rustc
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.
S-blockedStatus: Blocked on something else such as an RFC or other implementation work.
F-or_patterns`#![feature(or_patterns)]`
on Dec 15, 2019
Centril

Centril commented on Dec 24, 2019

@Centril
ContributorAuthor

This is almost unblocked now that #66296 has landed. However, we need more progress on or-patterns.

added
C-enhancementCategory: An issue proposing an enhancement or a PR with one.
on Jan 19, 2020
removed
S-blockedStatus: Blocked on something else such as an RFC or other implementation work.
on Feb 14, 2020
thekuom

thekuom commented on Mar 4, 2020

@thekuom
Contributor

Can I work on this one?

Centril

Centril commented on Mar 4, 2020

@Centril
Author
rustbot

rustbot commented on Mar 4, 2020

@rustbot

12 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcC-enhancementCategory: An issue proposing an enhancement or a PR with one.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.F-bindings_after_at`#![feature(bindings_after_at)]`F-or_patterns`#![feature(or_patterns)]`F-slice_patterns`#![feature(slice_patterns)]`T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @Centril@thekuom@JohnTitor@rustbot

    Issue actions

      Extend bindings_after_at (`b1 @ Some(b2)`) tests with nested `or_patterns` · Issue #67311 · rust-lang/rust