Closed
Description
Steps:
Compile tower-balance.
What happened:
Compiling tower-balance v0.3.0
error[E0034]: multiple applicable items in scope
--> /Users/rex/.cargo/registry/src/github.com-1ecc6299db9ec823/tower-balance-0.3.0/src/pool/mod.rs:373:47
|
373 | if let Poll::Ready(()) = self.balance.poll_ready(cx)? {
| ^^^^^^^^^^ multiple `poll_ready` found
|
note: candidate #1 is defined in an impl of the trait `tower_service::Service` for the type `p2c::service::Balance<_, _>`
--> /Users/rex/.cargo/registry/src/github.com-1ecc6299db9ec823/tower-balance-0.3.0/src/p2c/service.rs:234:5
|
234 | fn poll_ready(&mut self, cx: &mut Context<'_>) -> Poll<Result<(), Self::Error>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: candidate #2 is defined in an impl of the trait `tower_make::make_service::MakeService` for the type `_`
help: disambiguate the method call for candidate #1
|
373 | if let Poll::Ready(()) = tower_service::Service::poll_ready(&mut self.balance, cx)? {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
help: disambiguate the method call for candidate #2
|
373 | if let Poll::Ready(()) = tower_make::make_service::MakeService::poll_ready(&mut self.balance, cx)? {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error[E0034]: multiple applicable items in scope
--> /Users/rex/.cargo/registry/src/github.com-1ecc6299db9ec823/tower-balance-0.3.0/src/pool/mod.rs:418:37
|
418 | return self.balance.poll_ready(cx);
| ^^^^^^^^^^ multiple `poll_ready` found
|
note: candidate #1 is defined in an impl of the trait `tower_service::Service` for the type `p2c::service::Balance<_, _>`
--> /Users/rex/.cargo/registry/src/github.com-1ecc6299db9ec823/tower-balance-0.3.0/src/p2c/service.rs:234:5
|
234 | fn poll_ready(&mut self, cx: &mut Context<'_>) -> Poll<Result<(), Self::Error>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: candidate #2 is defined in an impl of the trait `tower_make::make_service::MakeService` for the type `_`
help: disambiguate the method call for candidate #1
|
418 | return tower_service::Service::poll_ready(&mut self.balance, cx);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
help: disambiguate the method call for candidate #2
|
418 | return tower_make::make_service::MakeService::poll_ready(&mut self.balance, cx);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: aborting due to 2 previous errors
For more information about this error, try `rustc --explain E0034`.
error: could not compile `tower-balance`.
Expected result:
No regression.
Notes:
See tower-rs/tower#423 (comment)
Metadata
Metadata
Assignees
Labels
Type
Projects
Milestone
Relationships
Development
No branches or pull requests
Participants
Activity
tower-balanceadityapk00/zecwallet-lite-electron#12Sherlock-Holo commentedon Mar 2, 2020
it happened to me compile error
jonhoo commentedon Mar 3, 2020
I ran regression with
cargo-bisect-rust, and got:Which suggests that the regression is present in nightly-2020-02-29, but somehow not in 0eb878d ? I'm working on bisecting further.
jonhoo commentedon Mar 3, 2020
cargo-bisect-rustclaims that the regression was caused by 55aee8d (#69255) by @estebank:jonhoo commentedon Mar 3, 2020
You can replicate by cloning
towerand running$ cargo check -p tower-balancejonhoo commentedon Mar 4, 2020
I wonder if this may somehow be a new manifestation of #60375?
pnkfelix commentedon Mar 4, 2020
triage: P-high, removing nomination. Assigning to @estebank initially (but feel free to clear assignment or reassign if you are overloaded)
16 remaining items