Open
Description
Picked up by the beta crater run
- https://crater-reports.s3.amazonaws.com/beta-1.46-rustdoc-1/beta-2020-07-24/gh/retro486.task-progress/log.txt
- https://crater-reports.s3.amazonaws.com/beta-1.46-1/beta-2020-07-24/reg/woff2-sys-0.0.1/log.txt
- https://crater-reports.s3.amazonaws.com/beta-1.46-1/beta-2020-07-24/reg/static_map_macros-0.2.0-beta/log.txt
I've not attempted to reproduce these locally, but they don't look spurious.
Metadata
Metadata
Assignees
Labels
Area: Procedural macrosCategory: This is a bug.Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable ExampleMedium priorityRelevant to the compiler team, which will review and decide on the PR/issue.Performance or correctness regression from one stable version to another.
Type
Projects
Milestone
Relationships
Development
No branches or pull requests
Activity
Mark-Simulacrum commentedon Aug 12, 2020
cc @petrochenkov proc macros / parser / resolution
petrochenkov commentedon Aug 12, 2020
The first two regressions are known from #73345 (comment), older versions of
cpp-macros
relied on some incorrect pretty-printing from rustc.Not sure about the third regression, perhaps @Aaron1011 has seen it in one of the other expansion-related PRs.
Aaron1011 commentedon Aug 12, 2020
The
static_map_macros
regressions is also due to pretty-printing changes:https://github.com/cbreeden/static-map/blob/14cada499fcbdeacf0735775978320f226876f8b/static_map_macros/src/lib.rs#L15-L25:
Before/after:
spastorino commentedon Aug 19, 2020
Assigning
P-medium
as discussed as part of the Prioritization Working Group procedure and removingI-prioritize
.rust-bin: Update to 1.46.0
Upgrade rust to version 1.46.0.