Skip to content

debuginfo/pretty-std-collections.rs test sometimes fails on macOS #78665

Closed
@JohnTitor

Description

@JohnTitor
Member

CI on macOS sometimes fails due to this failure:

failures:

---- [debuginfo-lldb] debuginfo/pretty-std-collections.rs stdout ----
NOTE: compiletest thinks it is using LLDB version 1200
NOTE: compiletest thinks it is using LLDB without native rust support

error: Error while running LLDB
stderr:
------------------------------------------
error: need to add support for DW_TAG_base_type '()' encoded with DW_ATE = 0x7, bit_size = 0
clang: CommandLine Error: Option 'h' registered more than once!
LLVM ERROR: inconsistency in registered CommandLine options

------------------------------------------

failures:
    [debuginfo-lldb] debuginfo/pretty-std-collections.rs

You can find the full log here: https://github.com/rust-lang-ci/rust/runs/1340649828
The failure occurs on #78501, #78489, and #78661 (at least).

Activity

added
O-macosOperating system: macOS
A-debuginfoArea: Debugging information in compiled programs (DWARF, PDB, etc.)
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
A-spuriousArea: Spurious failures in builds (spuriously == for no apparent reason)
C-bugCategory: This is a bug.
on Nov 2, 2020
JohnTitor

JohnTitor commented on Nov 2, 2020

@JohnTitor
MemberAuthor
added
A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.
and removed
T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
on Nov 2, 2020
self-assigned this
on Nov 2, 2020
added 2 commits that reference this issue on Nov 2, 2020
pietroalbini

pietroalbini commented on Nov 2, 2020

@pietroalbini
Member

Please ping me if another failure happens again.

29 remaining items

est31

est31 commented on Nov 16, 2020

@est31
Member

#79094

artemmukhin

artemmukhin commented on Nov 16, 2020

@artemmukhin
Contributor

@ehuss

Sorry, I'm not too familiar with lldb or the Rust integration. What do you mean by "LLDB without native Rust support"?
...building a custom lldb was removed over a year ago

You're right, seems like "LLDB with native Rust support" (which is basically LLDB with Rust support patches) is not used in rustc anymore. However, it is used in IntelliJ Rust and CodeLLDB AFAIK.

BTW, probably @tromey could tell something about error: need to add support for DW_TAG_base_type '()' encoded with DW_ATE = 0x7, bit_size = 0 error regarding LLDB? Was this problem fixed in the Rust-enabled LLDB?

@est31 There are really lots of ignored debugging tests, so I agree with you that disabling these tests on macOS won't make it much worse.

tromey

tromey commented on Nov 16, 2020

@tromey
Contributor

BTW, probably @tromey could tell something about error: need to add support for DW_TAG_base_type '()' encoded with DW_ATE = 0x7, bit_size = 0 error regarding LLDB? Was this problem fixed in the Rust-enabled LLDB?

Yes, but maybe not in the way you may be thinking. In LLDB, each language provides its own code to analyze DWARF. So, the Rust-specific DWARF analysis handles this case without issuing an error. See DWARFASTParserRust::ParseSimpleType for the DWARF-reading bit. Offhand I would expect it to use DW_ATE_void, and digging through the LLDB patches a bit supports this, but I'm not sure. This kind of difference is trivial to handle though.

added a commit that references this issue on Nov 19, 2020

Rollup merge of rust-lang#79094 - est31:ignore_macos, r=pietroalbini

552d8c5
ehuss

ehuss commented on Feb 6, 2021

@ehuss
Contributor

I think an unintended consequence of #79094 is that pretty-std-collections is no longer tested on any platform, and it has been broken over time (#81814).

est31

est31 commented on Feb 6, 2021

@est31
Member

@ehuss my PR only ignored the test on Mac OS. It should still be tested on Linux, no?

ehuss

ehuss commented on Feb 6, 2021

@ehuss
Contributor
est31

est31 commented on Feb 6, 2021

@est31
Member

@ehuss oh that's unfortunate. It was definitely not my intent when doing that. The gdb tests should still be run. At least when I change something in the gdb related text on my local Linux machine I get a test failure (otherwise a success). For some reason I don't get such a reaction when altering the lldb related text tho.

est31

est31 commented on Feb 6, 2021

@est31
Member

(To make it clear, the premise of #79094 was that it does still run all the tests on linux, but apparently the lldb ones were only run on mac OS.... I installed lldb locally on my Linux and it's broken.... maybe the solution is really to make the Linux box do sudo apt install lldb somewhere)

added a commit that references this issue on Sep 12, 2023

Auto merge of rust-lang#115128 - davidtwco:re-enable-debuginfo-test, …

960a5ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-debuginfoArea: Debugging information in compiled programs (DWARF, PDB, etc.)A-github-actionsArea: GitHub Actions (GHA)A-spuriousArea: Spurious failures in builds (spuriously == for no apparent reason)C-bugCategory: This is a bug.O-macosOperating system: macOST-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @ehuss@wesleywiser@davidtwco@tromey@pietroalbini

    Issue actions

      `debuginfo/pretty-std-collections.rs` test sometimes fails on macOS · Issue #78665 · rust-lang/rust