Skip to content

regression: Type aliases are bolded #86256

@camelid

Description

@camelid
Member

It looks like a CSS rule is being applied incorrectly.

It also looks weird if you click through to the type alias's page (Visibilities).

nightly (incorrect)

image

beta (correct)

image

Activity

added
C-bugCategory: This is a bug.
I-prioritizeIssue: Indicates that prioritization has been requested for this issue.
A-rustdoc-uiArea: Rustdoc UI (generated HTML)
on Jun 13, 2021
apiraino

apiraino commented on Jun 13, 2021

@apiraino
Contributor

I'm not really sure, could that be slipped in 5bd9146?

camelid

camelid commented on Jun 13, 2021

@camelid
MemberAuthor

It turns out it was actually much more recent. The PR causing the regression was #84703, cc @GuillaumeGomez.

MCVE

pub type Foo = u32;

pub struct Bar { pub f: Foo }

Bisection

searched nightlies: from nightly-2021-05-01 to nightly-2021-06-12
regressed nightly: nightly-2021-06-04
searched commits: from dbe459d to cc77ba4
regressed commit: da86509

bisected with cargo-bisect-rustc v0.6.0

Host triple: x86_64-apple-darwin
Reproduce with:

cargo bisect-rustc --prompt --start=2021-05-01 --end=2021-06-12 -- doc --open 
LeSeulArtichaut

LeSeulArtichaut commented on Jun 13, 2021

@LeSeulArtichaut
Contributor

The culprit CSS rule is here:

.impl, .method,
.type:not(.container-rustdoc), .associatedconstant,
.associatedtype {
flex-basis: 100%;
font-weight: 600;
margin-top: 16px;
margin-bottom: 10px;
position: relative;
}

It also caused #86069 which was fixed by #86078.

GuillaumeGomez

GuillaumeGomez commented on Jun 13, 2021

@GuillaumeGomez
Member

Ah, I have missed this one. Sending a fix.

added a commit that references this issue on Jun 13, 2021
f586d79
camelid

camelid commented on Jun 13, 2021

@camelid
MemberAuthor

Assigning priority as discussed in the prioritization working group.

@rustbot label: +P-medium -I-prioritize

added and removed
I-prioritizeIssue: Indicates that prioritization has been requested for this issue.
on Jun 13, 2021
GuillaumeGomez

GuillaumeGomez commented on Jun 13, 2021

@GuillaumeGomez
Member

The fix should be merged in less than 3 hours. ;)

camelid

camelid commented on Jun 13, 2021

@camelid
MemberAuthor

The fix should be merged in less than 3 hours. ;)

I know, but we had already agreed on a priority :)

GuillaumeGomez

GuillaumeGomez commented on Jun 13, 2021

@GuillaumeGomez
Member

Oh I see. Thanks for taking care of that then! :)

added
T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
on Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-rustdoc-uiArea: Rustdoc UI (generated HTML)C-bugCategory: This is a bug.P-mediumMedium priorityT-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.regression-from-stable-to-nightlyPerformance or correctness regression from stable to nightly.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @GuillaumeGomez@apiraino@jyn514@camelid@LeSeulArtichaut

      Issue actions

        regression: Type aliases are bolded · Issue #86256 · rust-lang/rust