-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
A-rustdoc-uiArea: Rustdoc UI (generated HTML)Area: Rustdoc UI (generated HTML)C-bugCategory: This is a bug.Category: This is a bug.P-mediumMedium priorityMedium priorityT-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.regression-from-stable-to-nightlyPerformance or correctness regression from stable to nightly.Performance or correctness regression from stable to nightly.
Metadata
Metadata
Assignees
Labels
A-rustdoc-uiArea: Rustdoc UI (generated HTML)Area: Rustdoc UI (generated HTML)C-bugCategory: This is a bug.Category: This is a bug.P-mediumMedium priorityMedium priorityT-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.regression-from-stable-to-nightlyPerformance or correctness regression from stable to nightly.Performance or correctness regression from stable to nightly.
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
apiraino commentedon Jun 13, 2021
I'm not really sure, could that be slipped in 5bd9146?
camelid commentedon Jun 13, 2021
It turns out it was actually much more recent. The PR causing the regression was #84703, cc @GuillaumeGomez.
MCVE
Bisection
searched nightlies: from nightly-2021-05-01 to nightly-2021-06-12
regressed nightly: nightly-2021-06-04
searched commits: from dbe459d to cc77ba4
regressed commit: da86509
bisected with cargo-bisect-rustc v0.6.0
Host triple: x86_64-apple-darwin
Reproduce with:
LeSeulArtichaut commentedon Jun 13, 2021
The culprit CSS rule is here:
rust/src/librustdoc/html/static/rustdoc.css
Lines 140 to 148 in fb3ea63
It also caused #86069 which was fixed by #86078.
GuillaumeGomez commentedon Jun 13, 2021
Ah, I have missed this one. Sending a fix.
Auto merge of rust-lang#86271 - GuillaumeGomez:fix-font-weight, r=jsha
camelid commentedon Jun 13, 2021
Assigning priority as discussed in the prioritization working group.
@rustbot label: +P-medium -I-prioritize
GuillaumeGomez commentedon Jun 13, 2021
The fix should be merged in less than 3 hours. ;)
camelid commentedon Jun 13, 2021
I know, but we had already agreed on a priority :)
GuillaumeGomez commentedon Jun 13, 2021
Oh I see. Thanks for taking care of that then! :)