Doublicated ld\ld64 executables added into rustc package, increasing it's size

[klensy]

Checked that on x86_64-pc-windows-msvc target,
found duplicates in versions:

rustc 1.56.0-beta.1 (e784c962e 2021-09-07)
rustc 1.57.0-nightly (b69fe5726 2021-09-10)

and no duplicates 2 duplicates (only rust-lld.exe, ld.exe) in stable rustc 1.55.0 (c8dfcfe04 2021-09-06), rustc 1.56.0-nightly (4e282795d 2021-07-31)
(bisecting is kinda slow on my connection)

there 3 copies of that executable, that gives ~ 187mb

@rustbot label +regression-from-stable-to-beta

[klensy]

Can be found in:

.rustup\toolchains\nightly-x86_64-pc-windows-msvc\lib\rustlib\x86_64-pc-windows-msvc\bin\gcc-ld\ld.exe
.rustup\toolchains\nightly-x86_64-pc-windows-msvc\lib\rustlib\x86_64-pc-windows-msvc\bin\gcc-ld\ld64.exe
.rustup\toolchains\nightly-x86_64-pc-windows-msvc\lib\rustlib\x86_64-pc-windows-msvc\bin\rust-lld.exe

I think they were added in #88250 and #85961.

and no duplicates (only ld.exe)

I believe ld is also a copy of ../rust-lld.

[apiraino]

Assigning priority as discussed in the Zulip thread of the Prioritization Working Group.

@rustbot label -I-prioritize +P-medium

[hkratz]

@rustbot claim

[hkratz]

Sorry, I only came across this issue just now. The copies are there for a reason, see linked issues.

Multiple things to consider:

• The files in the gcc-ld directory are only used with the -Z gcc-ld=lld unstable option. So they could be removed for beta and stable.
• They can be replaced with small Rust executables which just exec ../rust-lld -flavor ld <supplied args> and ../rust-lld -flavor ld64 <supplied args> respectively. I will be working on that for nightly.