Skip to content

Fix invalid primitive's methods link generation in core and alloc crate #89628

Closed
@GuillaumeGomez

Description

@GuillaumeGomez
Member

There are some broken links when generating primitives' methods using intra-doc links from the core and alloc crate. The list is here. It was introduced in #87073. At the time we merged because the change was really important and far outweighed this problem. But it would be nice to finish it. :)

Activity

added
T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
C-bugCategory: This is a bug.
A-intra-doc-linksArea: Intra-doc links, the ability to link to items in docs by name
on Oct 7, 2021
jyn514

jyn514 commented on Oct 7, 2021

@jyn514
Member

@GuillaumeGomez this is not a problem we can fix in rustdoc. It's a special case of #74481.

GuillaumeGomez

GuillaumeGomez commented on Oct 7, 2021

@GuillaumeGomez
MemberAuthor

I had in mind something like what you did #87073: provide a link through a markdown file depending whether we were in core/alloc or in std. If we are in a downstream crate, then we provide a "hard" link to the method in std. Having a more generic way to do so would be nice though.

jyn514

jyn514 commented on Oct 7, 2021

@jyn514
Member

@GuillaumeGomez that's what broke it in the first place. Relative links can never work for both the original item and the re-export.

jyn514

jyn514 commented on Oct 30, 2021

@jyn514
Member

I'm going to close this as a duplicate of #32130, I don't think we need multiple issues tracking the linkcheck exceptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-intra-doc-linksArea: Intra-doc links, the ability to link to items in docs by nameC-bugCategory: This is a bug.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @GuillaumeGomez@jyn514

        Issue actions

          Fix invalid primitive's methods link generation in core and alloc crate · Issue #89628 · rust-lang/rust