Skip to content

Tracking Issue for constify-ing CStr::from_bytes_with_nul_unchecked #90343

Closed
@LunaBorowska

Description

@LunaBorowska
Contributor

The feature gate for the issue is #![feature(const_cstr_unchecked)].

This is a tracking issue for constify-ing CStr::from_bytes_with_nul_unchecked.

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

Unresolved Questions

XXX --- list all the "unresolved questions" found in the RFC to ensure they are
not forgotten

Implementation history

Activity

added
C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFC
on Oct 27, 2021
added a commit that references this issue on Oct 27, 2021

Rollup merge of rust-lang#90344 - xfix:tracking-issue-const_cstr_unch…

623c3e1
Amanieu

Amanieu commented on Nov 18, 2021

@Amanieu
added
T-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.
on Nov 18, 2021
Amanieu

Amanieu commented on Nov 18, 2021

@Amanieu
Member

@rfcbot merge

rfcbot

rfcbot commented on Nov 18, 2021

@rfcbot
Collaborator

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

added
proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.
disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.
on Nov 18, 2021
added
final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.
and removed
proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.
on Dec 2, 2021
rfcbot

rfcbot commented on Dec 2, 2021

@rfcbot
Collaborator

🔔 This is now entering its final comment period, as per the review above. 🔔

added
to-announceAnnounce this issue on triage meeting
and removed
final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.
on Dec 12, 2021
rfcbot

rfcbot commented on Dec 12, 2021

@rfcbot
Collaborator

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

added 2 commits that reference this issue on Dec 13, 2021

Rollup merge of rust-lang#91855 - xfix:const_cstr_unchecked, r=dtolnay

c3275c1

Rollup merge of rust-lang#91855 - xfix:const_cstr_unchecked, r=dtolnay

ff214b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCT-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @Amanieu@LunaBorowska@apiraino@rfcbot

      Issue actions

        Tracking Issue for constify-ing CStr::from_bytes_with_nul_unchecked · Issue #90343 · rust-lang/rust