@@ -98,9 +98,9 @@ through each in detail.
9898 * ` ./x.py build src/tools/lld ` - same for LLD
9999 * ` ./x.py build ` - build the rest of rustc
100100
101- You'll likely need to update ` src/rustllvm/ *.cpp` to compile with updated
102- LLVM bindings. Note that you should use ` #ifdef ` and such to ensure that the
103- bindings still compile on older LLVM versions.
101+ You'll likely need to update [ ` llvm-wrapper/ *.cpp` ] [ `llvm-wrapper` ] to compile
102+ with updated LLVM bindings. Note that you should use ` #ifdef ` and such to ensure
103+ that the bindings still compile on older LLVM versions.
104104
105105 Note that ` profile = "compiler" ` and other defaults set by ` x.py setup `
106106 download LLVM from CI instead of building it from source. You should
@@ -133,18 +133,20 @@ through each in detail.
1331335 . Prepare a PR to ` rust-lang/rust ` . Work with maintainers of
134134 ` rust-lang/llvm-project ` to get your commit in a branch of that repository,
135135 and then you can send a PR to ` rust-lang/rust ` . You'll change at least
136- ` src/llvm-project ` and will likely also change ` src/rustllvm/* ` as well.
136+ ` src/llvm-project ` and will likely also change [ ` llvm-wrapper ` ] as well.
137137
138138For prior art, previous LLVM updates look like
139139[ #55835 ] ( https://github.com/rust-lang/rust/pull/55835 )
140140[ #47828 ] ( https://github.com/rust-lang/rust/pull/47828 )
141141[ #62474 ] ( https://github.com/rust-lang/rust/pull/62474 )
142142[ #62592 ] ( https://github.com/rust-lang/rust/pull/62592 ) . Note that sometimes it's
143- easiest to land ` src/rustllvm/* ` compatibility as a PR before actually updating
143+ easiest to land [ ` llvm-wrapper ` ] compatibility as a PR before actually updating
144144` src/llvm-project ` . This way while you're working through LLVM issues others
145145interested in trying out the new LLVM can benefit from work you've done to
146146update the C++ bindings.
147147
148+ [ `llvm-wrapper` ] : https://github.com/rust-lang/rust/tree/master/compiler/rustc_llvm/llvm-wrapper
149+
148150### Caveats and gotchas
149151
150152Ideally the above instructions are pretty smooth, but here's some caveats to
0 commit comments