Skip to content

Commit fa8dce1

Browse files
committed
Recommend waiting a bit for team nominations
1 parent f80902e commit fa8dce1

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

src/stabilization_guide.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -165,14 +165,16 @@ if something { /* XXX */ }
165165
[`Unstable Book`]: https://doc.rust-lang.org/unstable-book/index.html
166166
[`src/doc/unstable-book`]: https://github.com/rust-lang/rust/tree/master/src/doc/unstable-book
167167

168-
## Lang team nomination
168+
## Team nominations
169169

170-
When you feel the PR is ready for consideration by the lang team, you can [nominate the PR](https://lang-team.rust-lang.org/how_to/nominate.html) to get it on the list for discussion in the next meeting. You should also cc the other interacting teams to review the report:
170+
After the stabilization PR is opened with the stabilization report, wait a bit for potential immediate comments. When such immediate comments "simmer down" and you feel the PR is ready for consideration by the lang team, you can [nominate the PR](https://lang-team.rust-lang.org/how_to/nominate.html) to get it on the list for discussion in the next meeting. You should also cc the other interacting teams when applicable to review the language feature being stabilized and the stabilization report:
171171

172172
* `@rust-lang/types`, to look for type system interactions
173-
* `@rust-lang/compiler`, to vouch for implementation quality
174-
* `@rust-lang/opsem`, but only if this feature interacts with unsafe code and can create undefined behavior
175-
* `@rust-lang/libs-api`, but only if there are additions to the standard library
173+
* `@rust-lang/compiler`, to review implementation robustness
174+
* `@rust-lang/opsem`, if this feature interacts with unsafe code and can create undefined behavior
175+
* `@rust-lang/libs-api`, if there are additions to the standard library that affects standard library API or their guarantees
176+
177+
If you are not an organization member, you can simply ask your assigned reviewer to cc the relevant teams on your behalf.
176178

177179
## FCP proposed on the PR
178180

0 commit comments

Comments
 (0)