Skip to content

Commit 76ccbc3

Browse files
lqdlqd
authored
Merge pull request #2361 from Kobzol/triage-2026-01-06
Add 2026-01-06 triage
2 parents 9afdab1 + 255bac4 commit 76ccbc3

File tree

1 file changed

+144
-0
lines changed

1 file changed

+144
-0
lines changed

‎triage/2026/2026-01-06.md‎

Lines changed: 144 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,144 @@
1+
# 2026-01-06 Triage Log
2+
3+
Not many PRs were merged, as it was still mostly a holiday week. [#149681](https://github.com/rust-lang/rust/pull/149681) caused small regressions across the board, this is pending investigation.
4+
5+
Triage done by **@kobzol**.
6+
Revision range: [112a2742..7c04f5d2](https://perf.rust-lang.org/?start=112a274275d77ebc2b892f056a1e2fad141f4f08&end=7c04f5d216b5dcfff0a55fc20327a1c519004699&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:--------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 0.5% | [0.1%, 1.4%] | 146 |
13+
| Regressions ❌ <br /> (secondary) | 0.6% | [0.0%, 3.5%] | 91 |
14+
| Improvements ✅ <br /> (primary) | -3.1% | [-4.7%, -1.5%] | 2 |
15+
| Improvements ✅ <br /> (secondary) | -0.7% | [-6.4%, -0.1%] | 15 |
16+
| All ❌✅ (primary) | 0.4% | [-4.7%, 1.4%] | 148 |
17+
18+
19+
2 Regressions, 0 Improvements, 7 Mixed; 4 of them in rollups
20+
51 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
Use more principled check for generics in const ops [#150519](https://github.com/rust-lang/rust/pull/150519) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=056908d7f44ab901ae6573cf2d9c1d8b166ed1c5&end=a47f4dfd7f496ed51a383c540497899f9e3f91b4&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 0.2% | [0.1%, 0.3%] | 6 |
29+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.2%, 0.2%] | 1 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 0.2% | [0.1%, 0.3%] | 6 |
33+
34+
- Tiny regression on the diesel benchmark.
35+
- The compiler does more work here, and this fixes an ICE, so it seems warranted.
36+
- Marked as triaged.
37+
38+
MGCA: Support for tuple constructors [#150603](https://github.com/rust-lang/rust/pull/150603) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=451b7b6c775a2378fd18d2560bbfb31c3695d1cc&end=6885bdf1af7e0435b80bf79a780c3fe7a495094f&stat=instructions:u)
39+
40+
| (instructions:u) | mean | range | count |
41+
|:----------------------------------:|:----:|:------------:|:-----:|
42+
| Regressions ❌ <br /> (primary) | - | - | 0 |
43+
| Regressions ❌ <br /> (secondary) | 0.1% | [0.1%, 0.2%] | 11 |
44+
| Improvements ✅ <br /> (primary) | - | - | 0 |
45+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
46+
| All ❌✅ (primary) | - | - | 0 |
47+
48+
- The regressions are only on a few secondary stress tests and they are tiny.
49+
- Marked as triaged.
50+
51+
#### Mixed
52+
53+
Remove the explicit branch hint from const_panic [#150386](https://github.com/rust-lang/rust/pull/150386) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=b082bd59d2f6d74913b904ffdb81c0b9dd09022c&end=d874dce1252fe409ce13e64d773046853bf5e6ca&stat=instructions:u)
54+
55+
| (instructions:u) | mean | range | count |
56+
|:----------------------------------:|:-----:|:--------------:|:-----:|
57+
| Regressions ❌ <br /> (primary) | 0.6% | [0.5%, 0.7%] | 2 |
58+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
59+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.5%, -0.4%] | 2 |
60+
| Improvements ✅ <br /> (secondary) | -0.1% | [-0.1%, -0.0%] | 3 |
61+
| All ❌✅ (primary) | 0.1% | [-0.5%, 0.7%] | 4 |
62+
63+
- Over all benchmarks it's a wash.
64+
- Marked as triaged.
65+
66+
Make inliner cycle detection a fallible process [#147361](https://github.com/rust-lang/rust/pull/147361) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=629b092f8fab1b0370dfb749c4f5e00e70169dd2&end=2848c2ebe9a8a604cd63455263299d7258bc8252&stat=instructions:u)
67+
68+
| (instructions:u) | mean | range | count |
69+
|:----------------------------------:|:-----:|:--------------:|:-----:|
70+
| Regressions ❌ <br /> (primary) | 0.6% | [0.3%, 1.0%] | 4 |
71+
| Regressions ❌ <br /> (secondary) | 0.8% | [0.1%, 1.3%] | 6 |
72+
| Improvements ✅ <br /> (primary) | -1.0% | [-4.9%, -0.1%] | 8 |
73+
| Improvements ✅ <br /> (secondary) | -0.6% | [-6.5%, -0.1%] | 18 |
74+
| All ❌✅ (primary) | -0.5% | [-4.9%, 1.0%] | 12 |
75+
76+
- The nalgebra win looks real.
77+
- This changes inlining behavior, so that always perturbs compile times.
78+
- Marked as triaged.
79+
80+
Rollup of 3 pull requests [#150582](https://github.com/rust-lang/rust/pull/150582) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=a47f4dfd7f496ed51a383c540497899f9e3f91b4&end=1b4325211c3228dd10eea12e9b3f749f87363d95&stat=instructions:u)
81+
82+
| (instructions:u) | mean | range | count |
83+
|:----------------------------------:|:-----:|:--------------:|:-----:|
84+
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.2%] | 1 |
85+
| Regressions ❌ <br /> (secondary) | 0.1% | [0.1%, 0.2%] | 2 |
86+
| Improvements ✅ <br /> (primary) | -0.1% | [-0.2%, -0.1%] | 4 |
87+
| Improvements ✅ <br /> (secondary) | -0.7% | [-1.8%, -0.1%] | 3 |
88+
| All ❌✅ (primary) | -0.1% | [-0.2%, 0.2%] | 5 |
89+
90+
- Tiny changes, overall it's a wash.
91+
- Marked as triaged.
92+
93+
Rollup of 7 pull requests [#150669](https://github.com/rust-lang/rust/pull/150669) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f8b1d59a81c700cb7aa25cf69e3032b3ce333150&end=5afdf5d8c0377d6babd2504986982b5e5d724798&stat=instructions:u)
94+
95+
| (instructions:u) | mean | range | count |
96+
|:----------------------------------:|:-----:|:--------------:|:-----:|
97+
| Regressions ❌ <br /> (primary) | 0.7% | [0.7%, 0.7%] | 1 |
98+
| Regressions ❌ <br /> (secondary) | 0.1% | [0.1%, 0.1%] | 1 |
99+
| Improvements ✅ <br /> (primary) | - | - | 0 |
100+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.6%, -0.2%] | 4 |
101+
| All ❌✅ (primary) | 0.7% | [0.7%, 0.7%] | 1 |
102+
103+
- The regressed cargo benchmark seems a bit noisy.
104+
- Over all benchmarks it's a wash, I don't think we need to investigate further.
105+
- Marked as triaged.
106+
107+
Rollup of 3 pull requests [#150682](https://github.com/rust-lang/rust/pull/150682) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=e29fcf45e4ae686d77b490bf07320f0d3a2cf35f&end=451b7b6c775a2378fd18d2560bbfb31c3695d1cc&stat=instructions:u)
108+
109+
| (instructions:u) | mean | range | count |
110+
|:----------------------------------:|:-----:|:--------------:|:-----:|
111+
| Regressions ❌ <br /> (primary) | 0.5% | [0.1%, 1.5%] | 154 |
112+
| Regressions ❌ <br /> (secondary) | 0.7% | [0.0%, 3.5%] | 87 |
113+
| Improvements ✅ <br /> (primary) | - | - | 0 |
114+
| Improvements ✅ <br /> (secondary) | -0.1% | [-0.1%, -0.1%] | 4 |
115+
| All ❌✅ (primary) | 0.5% | [0.1%, 1.5%] | 154 |
116+
117+
- The regression was caused by [#149681](https://github.com/rust-lang/rust/pull/149681), continuing discussion there.
118+
- Marked as triaged.
119+
120+
Rename the gcc component to gcc-dev [#150535](https://github.com/rust-lang/rust/pull/150535) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=6885bdf1af7e0435b80bf79a780c3fe7a495094f&end=0d162b25edd5bf0dba9a22e83b614f1113e90474&stat=instructions:u)
121+
122+
| (instructions:u) | mean | range | count |
123+
|:----------------------------------:|:-----:|:--------------:|:-----:|
124+
| Regressions ❌ <br /> (primary) | - | - | 0 |
125+
| Regressions ❌ <br /> (secondary) | 0.6% | [0.5%, 0.6%] | 3 |
126+
| Improvements ✅ <br /> (primary) | - | - | 0 |
127+
| Improvements ✅ <br /> (secondary) | -0.1% | [-0.2%, -0.1%] | 9 |
128+
| All ❌✅ (primary) | - | - | 0 |
129+
130+
- Noise, this only changed a CI component.
131+
- Marked as triaged.
132+
133+
Rollup of 3 pull requests [#150700](https://github.com/rust-lang/rust/pull/150700) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=bd33b83cfdbac9bffa3b04aaef95ec97827909a9&end=4fa80a5e733e2202d7ca4c203c2fdfda41cfe7dc&stat=instructions:u)
134+
135+
| (instructions:u) | mean | range | count |
136+
|:----------------------------------:|:-----:|:--------------:|:-----:|
137+
| Regressions ❌ <br /> (primary) | - | - | 0 |
138+
| Regressions ❌ <br /> (secondary) | 0.0% | [0.0%, 0.1%] | 2 |
139+
| Improvements ✅ <br /> (primary) | -0.1% | [-0.1%, -0.1%] | 1 |
140+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.8%, -0.0%] | 4 |
141+
| All ❌✅ (primary) | -0.1% | [-0.1%, -0.1%] | 1 |
142+
143+
- Noise.
144+
- Marked as triaged.

0 commit comments

Comments
 (0)