Skip to content

Commit 3db381b

Browse files
rami3ldjc
authored andcommitted
style(rustup-init/sh): ignore shellcheck SC2086 false positives
Since we're really using `$_retry` for command building, this is clearly an exception to the SC2086 rule, as listed in https://www.shellcheck.net/wiki/SC2086.
1 parent 0e8cf1a commit 3db381b

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

rustup-init.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -638,15 +638,18 @@ downloader() {
638638
get_ciphersuites_for_curl
639639
_ciphersuites="$RETVAL"
640640
if [ -n "$_ciphersuites" ]; then
641+
# shellcheck disable=SC2086
641642
_err=$(curl $_retry --proto '=https' --tlsv1.2 --ciphers "$_ciphersuites" --silent --show-error --fail --location "$1" --output "$2" 2>&1)
642643
_status=$?
643644
else
644645
warn "Not enforcing strong cipher suites for TLS, this is potentially less secure"
645646
if ! check_help_for "$3" curl --proto --tlsv1.2; then
646647
warn "Not enforcing TLS v1.2, this is potentially less secure"
648+
# shellcheck disable=SC2086
647649
_err=$(curl $_retry --silent --show-error --fail --location "$1" --output "$2" 2>&1)
648650
_status=$?
649651
else
652+
# shellcheck disable=SC2086
650653
_err=$(curl $_retry --proto '=https' --tlsv1.2 --silent --show-error --fail --location "$1" --output "$2" 2>&1)
651654
_status=$?
652655
fi

0 commit comments

Comments
 (0)