Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository section generated in package.json is slightly wrong, missing git+ for the url #1477

Open
IceTDrinker opened this issue Feb 18, 2025 · 0 comments

Comments

@IceTDrinker
Copy link

IceTDrinker commented Feb 18, 2025

🐛 Bug description

When publishing a package built with wasm-pack we saw the following warning

npm warn publish npm auto-corrected some errors in your package.json when publishing.  Please run "npm pkg fix" to address these errors.
npm warn publish errors corrected:
npm warn publish "repository.url" was normalized to "git+https://github.com/zama-ai/tfhe-rs.git"

🤔 Expected Behavior

wasm-pack packages should have a well formed package.json namely this section:

  "repository": {
    "type": "git",
    "url": "https://github.com/zama-ai/tfhe-rs.git"
  },

should contain the git+ as corrected by npm:

  "repository": {
    "type": "git",
    "url": "git+https://github.com/zama-ai/tfhe-rs.git"
  },

👟 Steps to reproduce

Using

wasm-pack build --release --target=web should be enough on any wasm enabled project

🌍 Your environment

Include the relevant details of your environment.
wasm-pack version: 0.13.1
rustc version: nightly-2024-11-29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant