Settings icon_path doesn't seem to do anything on Web or MacOS?

[bwinton]

Describe the bug
I've tried a few different variants (my latest is here), but no matter what I put there, the MacOS icon in the dock is still the standard "exec" icon, and there is no favicon on the webpage…

To Reproduce
Add an icon_path to your settings, look for that icon, fail to find it. 😉

Also when I run cargo web deploy and try to run the resulting code, it gives me the error:

Error loading Rust wasm module 'mazes': RuntimeError: unreachable executed
    initialize http://bwinton.github.io/mazes/mazes.js:1067
    <anonymous> http://bwinton.github.io/mazes/mazes.js:41

Environment and versions (please complete the following information):

• Environment: macOS Catalina
• Rust compiler version: Rust nightly 1.46.0
• Quicksilver verison: "0.4.0-alpha0.5"

[lenscas]

looks like the path is icon_path: "static/maze.png" try it without the static so it becomes /maze.png.

[bwinton]

When I changed it, I get:

$ ls static/maze.png
static/maze.png
$ cargo run
    Finished dev [unoptimized + debuginfo] target(s) in 0.19s
     Running `target/debug/mazes`
thread 'main' panicked at 'Failed to load image: IoError(Os { code: 2, kind: NotFound, message: "No such file or directory" })', /Users/bwinton/.cargo/registry/src/github.com-1ecc6299db9ec823/blinds-0.1.6/src/window.rs:116:37
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

[ryanisaacg]

Regarding desktop icons, winit (the library quicksilver uses for windowing) does not support window icons on macOS. If upstream support is added, then it will work fine.

Regarding the path to the icon on desktop, I think that's definitely a bug.

I think that the path is wrong on the web, which is your problem there. Try just 'maze.png' and compile for the web.

[bwinton]

I get the same Error loading Rust wasm module 'mazes': RuntimeError: unreachable executed as in the original report.

(Is it trying to load the image from the filesystem in the web version? Is there some sort of "resource bundle" task I need to run first? Or maybe a config file I need to write?)

[lenscas]

you don't need to bundle it, as cargo web just allows you to reference everything inside the static folder as if that was the root. (So, maze.png instead of static/maze.png).

However, a browser already automatically asks for the icon file at favicon.ico, so just having an .ico file inside the static directory should probably be enough to get it to work for browsers?
`