Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Material Design Icon glyphs not in new v3.0 codepoints? #1795

Open
3 tasks done
J-MR-T opened this issue Feb 5, 2025 · 5 comments
Open
3 tasks done

Some Material Design Icon glyphs not in new v3.0 codepoints? #1795

J-MR-T opened this issue Feb 5, 2025 · 5 comments

Comments

@J-MR-T
Copy link

J-MR-T commented Feb 5, 2025

Requirements

  • I have searched the issues for my issue and found nothing related or helpfulincluded what I found
  • I have searched the FAQ for help
  • I have checked the Wiki for help

Experienced Behavior

Hi :)

I'm in the process of replacing my version 2 nerd fonts across the board, so moving to the new code points for material design icons after #365 / #773. But in trying to migrate one of the glyphs: nf-mdi-square_inc (the old, conflicting codepoint was U+F9C9 (柳)), I couldn't find a replacement in the cheatsheet:

Image

(searching for just square doesn't bring up the icon either; nor do external tools like nerdfix)

Is this intended? Are there some material design icon glyphs that were simply removed and not allocated new codepoints in the move? From what I can tell, the symbol was not removed from MD itself, so I'm a bit confused ^^.

@Finii
Copy link
Collaborator

Finii commented Feb 6, 2025

According to this list: loichyan/nerdfix#9 (comment) I did a manual search for that square_inc icon and found no substitute (i.e. it has been dropped without replacement).

Looked manually through all MD icons, and the only half-way similar one is square-circle or circle-box-outline, but then even the border is different, and so I guess you would have to look yourself. I would use fontforge or similar for easier viewing.

Is this intended? Are there some material design icon glyphs that were simply removed and not allocated new codepoints in the move?

Well, it was not only a move, it was also an update. So they are dropped upstream.

the symbol was not removed from MD itself

Not?! Can you show me the symbol in MD?

@J-MR-T
Copy link
Author

J-MR-T commented Feb 6, 2025

Apologies, it seems like the page I found showing the icons was outdated itself (I was fooled by a "-dev" in the version name...), I now saw the official Google Fonts MDI browser, and can't find it there either, and the thread you link to also mentions it as being dropped without a replacement. Thanks for the clarification!

To make this clearer in the future, it might be worth amending this disclaimer on the cheatsheet page:

To find for example the replacement for nf-mdi-altimeter enter just altimeter in the search box.

This makes it sound like there should a definitive replacement. Maybe by adding something like Note that the upstream update also left some glyphs removed and without a definitive replacement, the situation would be clearer?


But as the core issue here is resolved, I'll close this for now.

@J-MR-T J-MR-T closed this as completed Feb 6, 2025
@Finii
Copy link
Collaborator

Finii commented Feb 6, 2025

Maybe by adding something like

Great suggestion. Reopening to not-forget.

BTW, we use (and always used) the (free) https://pictogrammers.com/library/mdi/ and not the (Google) https://m3.material.io/styles/icons/overview; the naming can be confusing.

https://github.com/Templarian/MaterialDesign
https://github.com/google/material-design-icons

@Finii Finii reopened this Feb 6, 2025
@Finii
Copy link
Collaborator

Finii commented Feb 7, 2025

Maybe by adding something like

Maybe you can help me and tell me and tell me where to add this?

For the latest release and the Devicons update there is such a note already:

Image

So probably in the 3.0.0 release notes? Will anybody read them nowadays? Where would you have expected that piece of information?

Thank you,

Fini


Edit:

The real breaking PR was #1156 🤔

Maybe mention here in the release notes, they just talk about old and new set, not that the new set has all old set icons or even is a direct replacement.

Image

V3.0.0 release notes snippet

@J-MR-T
Copy link
Author

J-MR-T commented Feb 7, 2025

Where would you have expected that piece of information?

I read the line about finding a replacement here:
https://www.nerdfonts.com/cheat-sheet :

Preview

Because the current phrasing there sounds a bit like there should be direct replacements for everything, I would have added this note there.

But the v3.0.0 release notes are definitely a good place to duplicate this info as well, as this page references v3.0.0 :)


Thanks for considering how this can be documented best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants