From cc8ee68bb6f28c39fb71ef16f7492e1c11861e09 Mon Sep 17 00:00:00 2001 From: sadath-12 Date: Thu, 28 Dec 2023 01:03:15 +0530 Subject: [PATCH] opt Signed-off-by: sadath-12 --- .github/workflows/validate-crd.yaml | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/.github/workflows/validate-crd.yaml b/.github/workflows/validate-crd.yaml index ac4fe1cbf31..e7ba8dad8bd 100644 --- a/.github/workflows/validate-crd.yaml +++ b/.github/workflows/validate-crd.yaml @@ -3,6 +3,7 @@ on: pull_request: paths: - 'pkg/k8s/apis/cilium.io/client/crds/v1alpha1/*.yaml' + jobs: check-version: runs-on: ubuntu-22.04 @@ -10,12 +11,16 @@ jobs: - name: Check for CRD changes and version update run: | if git diff --name-only HEAD^ | grep -q 'pkg/k8s/apis/cilium.io/client/crds/v1alpha1/'; then - old_version=$(grep 'CustomResourceDefinitionSchemaVersion' pkg/k8s/apis/cilium.io/v1alpha1/register.go | awk -F'"' '{print $2}') - - new_version=$(grep 'CustomResourceDefinitionSchemaVersion' pkg/k8s/apis/cilium.io/v1alpha1/register.go | awk -F'"' '{print $2}') + if git diff --name-only HEAD^ | grep -q 'pkg/k8s/apis/cilium.io/v1alpha1/register.go'; then + old_version=$(grep 'CustomResourceDefinitionSchemaVersion' tetragon/pkg/k8s/apis/cilium.io/v1alpha1/register.go | awk -F'"' '{print $2}') + new_version=$(grep 'CustomResourceDefinitionSchemaVersion' tetragon/pkg/k8s/apis/cilium.io/v1alpha1/register.go | awk -F'"' '{print $2}') - if [ "$old_version" == "$new_version" ]; then - echo "Error: CRD version not updated! Please update the CustomResourceDefinitionSchemaVersion in register.go" + if [ "$old_version" == "$new_version" ]; then + echo "Error: CRD version not updated! Please update the CustomResourceDefinitionSchemaVersion in register.go" + exit 1 + fi + else + echo "Error: CRD files changed, but register.go not modified." exit 1 fi else