-
-
Notifications
You must be signed in to change notification settings - Fork 17
Open
Labels
breaking changeIntroduces changes that break backward compatibility or alter the public API.Introduces changes that break backward compatibility or alter the public API.coreChanges affecting the core logic or main components of the project, in root/internal/testing pkgChanges affecting the core logic or main components of the project, in root/internal/testing pkgenhancementRequest or implementation of a new feature or improvement.Request or implementation of a new feature or improvement.help wantedExtra help or attention is needed to move this issue forward.Extra help or attention is needed to move this issue forward.operatorRelated to Operator logic or components (chainable transformation in reactive programming)Related to Operator logic or components (chainable transformation in reactive programming)
Description
Currently, we have operators named ThrottleTime, SampleTime, WindowTime...
I think BufferWithTime should be renamed to BufferTime. Same quesiton for BufferWithCount -> BufferCount.
Should BufferWithTimeOrCount be renamed too?
RxJS has the following naming: buffer, bufferWithCount, bufferWithTime, and bufferWithTimeOrCount
Also update tests, examples, doc and the instructions in contributing guide.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
breaking changeIntroduces changes that break backward compatibility or alter the public API.Introduces changes that break backward compatibility or alter the public API.coreChanges affecting the core logic or main components of the project, in root/internal/testing pkgChanges affecting the core logic or main components of the project, in root/internal/testing pkgenhancementRequest or implementation of a new feature or improvement.Request or implementation of a new feature or improvement.help wantedExtra help or attention is needed to move this issue forward.Extra help or attention is needed to move this issue forward.operatorRelated to Operator logic or components (chainable transformation in reactive programming)Related to Operator logic or components (chainable transformation in reactive programming)