From e5d9dd07be3c983d4259d4ad0395d40897239eec Mon Sep 17 00:00:00 2001 From: Sander van Hooft Date: Tue, 13 Jan 2026 10:03:07 +0100 Subject: [PATCH] Fix Administrations endpoint URLs to use absolute paths The Administrations endpoint requires absolute URLs to bypass the connector's base URL which includes the administration ID. This fixes 404 errors when calling administrations()->all() or administrations()->get(). --- src/Api/Administrations/GetAdministrationRequest.php | 11 +++++------ src/Api/Administrations/GetAdministrationsRequest.php | 11 +++++------ 2 files changed, 10 insertions(+), 12 deletions(-) diff --git a/src/Api/Administrations/GetAdministrationRequest.php b/src/Api/Administrations/GetAdministrationRequest.php index 2f69f9c..741af3c 100644 --- a/src/Api/Administrations/GetAdministrationRequest.php +++ b/src/Api/Administrations/GetAdministrationRequest.php @@ -15,14 +15,13 @@ public function __construct( // } + /** + * Returns the full URL to bypass the connector's base URL. + * The Administrations endpoint does not use an administration ID in the path. + */ public function resolveEndpoint(): string { - return '/administrations/'.$this->id; - } - - public function resolveBaseUrl(): string - { - return 'https://moneybird.com/api/v2'; + return 'https://moneybird.com/api/v2/administrations/'.$this->id; } public function createDtoFromResponse(Response $response): Administration diff --git a/src/Api/Administrations/GetAdministrationsRequest.php b/src/Api/Administrations/GetAdministrationsRequest.php index 465c37f..471aa61 100644 --- a/src/Api/Administrations/GetAdministrationsRequest.php +++ b/src/Api/Administrations/GetAdministrationsRequest.php @@ -9,14 +9,13 @@ class GetAdministrationsRequest extends BaseJsonGetRequest { + /** + * Returns the full URL to bypass the connector's base URL. + * The Administrations endpoint does not use an administration ID in the path. + */ public function resolveEndpoint(): string { - return '/administrations'; - } - - public function resolveBaseUrl(): string - { - return 'https://moneybird.com/api/v2'; + return 'https://moneybird.com/api/v2/administrations'; } public function createDtoFromResponse(Response $response): Administration