Merge pull request json-iterator#304 from Quasilyte/quasilyte/emptyFallthrough

taowen · web-flow · commit 2433035e5132 · 2018-09-14T09:48:43.000+08:00
use multi-value case clause instead of fallthrough
diff --git a/iter_float.go b/iter_float.go
@@ -145,9 +145,7 @@ non_decimal_loop:
 				}
 				// too many decimal places
 				return iter.readFloat32SlowPath()
-			case invalidCharForNumber:
-				fallthrough
-			case dotInNumber:
+			case invalidCharForNumber, dotInNumber:
 				return iter.readFloat32SlowPath()
 			}
 			decimalPlaces++
@@ -286,9 +284,7 @@ non_decimal_loop:
 				}
 				// too many decimal places
 				return iter.readFloat64SlowPath()
-			case invalidCharForNumber:
-				fallthrough
-			case dotInNumber:
+			case invalidCharForNumber, dotInNumber:
 				return iter.readFloat64SlowPath()
 			}
 			decimalPlaces++

Original file line number	Diff line number	Diff line change
`@@ -145,9 +145,7 @@ non_decimal_loop:`
`145`	`145`	`}`
`146`	`146`	`// too many decimal places`
`147`	`147`	`return iter.readFloat32SlowPath()`
`148`		`- case invalidCharForNumber:`
`149`		`- fallthrough`
`150`		`- case dotInNumber:`
	`148`	`+ case invalidCharForNumber, dotInNumber:`
`151`	`149`	`return iter.readFloat32SlowPath()`
`152`	`150`	`}`
`153`	`151`	`decimalPlaces++`
`@@ -286,9 +284,7 @@ non_decimal_loop:`
`286`	`284`	`}`
`287`	`285`	`// too many decimal places`
`288`	`286`	`return iter.readFloat64SlowPath()`
`289`		`- case invalidCharForNumber:`
`290`		`- fallthrough`
`291`		`- case dotInNumber:`
	`287`	`+ case invalidCharForNumber, dotInNumber:`
`292`	`288`	`return iter.readFloat64SlowPath()`
`293`	`289`	`}`
`294`	`290`	`decimalPlaces++`