Skip to content

Commit 5b17a56

Browse files
committed
Adjust default color args
1 parent 286f88d commit 5b17a56

File tree

3 files changed

+4
-18
lines changed

3 files changed

+4
-18
lines changed

src/context.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -779,25 +779,25 @@ namespace Sass {
779779
void register_built_in_functions(Context& ctx, Env* env)
780780
{
781781
using namespace Functions;
782-
register_overload_stub(ctx, "rgb", env, 3);
782+
register_overload_stub(ctx, "rgb", env, 1);
783783
register_function(ctx, rgb_4_sig, rgb_4, 4, env);
784784
register_function(ctx, rgb_3_sig, rgb_3, 3, env);
785785
register_function(ctx, rgb_2_sig, rgb_2, 2, env);
786786
register_function(ctx, rgb_1_sig, rgb_1, 1, env);
787787

788-
register_overload_stub(ctx, "rgba", env, 4);
788+
register_overload_stub(ctx, "rgba", env, 1);
789789
register_function(ctx, rgba_4_sig, rgba_4, 4, env);
790790
register_function(ctx, rgba_3_sig, rgba_3, 3, env);
791791
register_function(ctx, rgba_2_sig, rgba_2, 2, env);
792792
register_function(ctx, rgba_1_sig, rgba_1, 1, env);
793793

794-
register_overload_stub(ctx, "hsl", env, 3);
794+
register_overload_stub(ctx, "hsl", env, 1);
795795
register_function(ctx, hsl_4_sig, hsl_4, 4, env);
796796
register_function(ctx, hsl_3_sig, hsl_3, 3, env);
797797
register_function(ctx, hsl_2_sig, hsl_2, 2, env);
798798
register_function(ctx, hsl_1_sig, hsl_1, 1, env);
799799

800-
register_overload_stub(ctx, "hsla", env, 4);
800+
register_overload_stub(ctx, "hsla", env, 1);
801801
register_function(ctx, hsla_4_sig, hsla_4, 4, env);
802802
register_function(ctx, hsla_3_sig, hsla_3, 3, env);
803803
register_function(ctx, hsla_2_sig, hsla_2, 2, env);

src/eval.cpp

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -294,15 +294,12 @@ namespace Sass {
294294
if (Argument* arg = Cast<Argument>(item)) item = arg->value();
295295
// check if we got passed a list of args (investigate)
296296
if (List* scalars = Cast<List>(item)) {
297-
// debug_ast(scalars);
298297
if (variables.size() == 1) {
299298
Expression* var = scalars;
300299
env.set_local(variables[0], var);
301300
} else {
302301
// XXX: this is never hit via spec tests
303-
// std::cerr << "qweqwe";
304302
for (size_t j = 0, K = variables.size(); j < K; ++j) {
305-
// std::cerr << "set next item\n";
306303
Expression* res = j >= scalars->length()
307304
? SASS_MEMORY_NEW(Null, expr->pstate())
308305
: scalars->at(j);
@@ -1213,13 +1210,11 @@ namespace Sass {
12131210

12141211
Expression* Eval::operator()(Variable* v)
12151212
{
1216-
// return SASS_MEMORY_NEW(Number, "", 1);
12171213
Expression_Obj value;
12181214
Env* env = environment();
12191215
std::string name(v->name());
12201216
EnvResult rv(env->find(name));
12211217
if (rv.found) value = static_cast<Expression*>(rv.it->second.ptr());
1222-
// else error("Undefined variable: \"" + v->name() + "\".", v->pstate(), traces);
12231218
else error("Undefined variable.", v->pstate(), traces);
12241219
if (Argument* arg = Cast<Argument>(value)) value = arg->value();
12251220

@@ -1471,8 +1466,6 @@ namespace Sass {
14711466
feature = (feature ? feature->perform(this) : 0);
14721467
Expression_Obj value = e->value();
14731468
value = (value ? value->perform(this) : 0);
1474-
// if (feature) std::cerr << "feature: [" << feature->to_string() << "]\n";
1475-
// if (value) std::cerr << "value: [" << value->to_string() << "]\n";
14761469
Expression* ee = SASS_MEMORY_NEW(At_Root_Query,
14771470
e->pstate(),
14781471
Cast<String>(feature),
@@ -1487,7 +1480,6 @@ namespace Sass {
14871480

14881481
Expression* Eval::operator()(Argument* a)
14891482
{
1490-
// std::cerr << "EVAL ARGUMENT\n";
14911483
Expression_Obj val = a->value()->perform(this);
14921484
bool is_rest_argument = a->is_rest_argument();
14931485
bool is_keyword_argument = a->is_keyword_argument();

src/listize.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,10 @@ namespace Sass {
2626
Expression* Listize::operator()(SelectorList* sel)
2727
{
2828
List_Obj l = SASS_MEMORY_NEW(List, sel->pstate(), sel->length(), SASS_COMMA);
29-
// l->from_selector(true);
3029
for (size_t i = 0, L = sel->length(); i < L; ++i) {
3130
if (!sel->at(i)) continue;
3231
l->append(sel->at(i)->perform(this));
3332
}
34-
// debug_ast(l);
35-
// std::cerr << "[" << l->inspect() << "]\n";
3633
if (l->length()) return l.detach();
3734
return SASS_MEMORY_NEW(Null, l->pstate());
3835
}
@@ -49,12 +46,9 @@ namespace Sass {
4946

5047
Expression* Listize::operator()(ComplexSelector* sel)
5148
{
52-
// std::string text(sel->to_css());
53-
// return SASS_MEMORY_NEW(String_Quoted, sel->pstate(), text);
5449
List_Obj l = SASS_MEMORY_NEW(List, sel->pstate(), 0, SASS_SPACE );
5550
// ToDo: investigate what this does
5651
// Note: seems reated to parent ref
57-
// l->from_selector(true);
5852

5953
for (auto component : sel->elements()) {
6054
if (CompoundSelectorObj compound = Cast<CompoundSelector>(component)) {

0 commit comments

Comments
 (0)