Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist display mode / subdisplay options in querystring #25

Open
jacobwegner opened this issue Sep 8, 2020 · 1 comment · Fixed by #40
Open

Persist display mode / subdisplay options in querystring #25

jacobwegner opened this issue Sep 8, 2020 · 1 comment · Fixed by #40
Assignees

Comments

@jacobwegner
Copy link
Contributor

jacobwegner commented Sep 8, 2020

Users should be able to copy the current URL and have the display mode / subdisplay options preserved (e.g, folio mode with only folios visible).

When users change to another display mode. that "subdisplay" state should reset (see discussion in #26).

@jacobwegner
Copy link
Contributor Author

@jtauber This is ready for review via https://deploy-preview-47--sv-mini.netlify.app/reader/urn:cts:greekLit:tlg0012.tlg001.perseus-grc2:1.1-1.7

e.g. the following URL will open in metrical display mode:

https://deploy-preview-47--sv-mini.netlify.app/reader/urn:cts:greekLit:tlg0012.tlg001.perseus-grc2:1.1-1.7?mode=metrical

If you select another version from the library widget, we are currently reverting to default mode:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants