Merge pull request #458 from scala/backport-lts-3.3-23355

Backport "improvement: Improve efficiency of completions" to 3.3 LTS

Author: tgodzik

compiler/src/dotty/tools/dotc/interactive/Completion.scala

@@ -332,7 +332,7 @@ object Completion:
       (sym.companionClass.exists && sym.companionClass.is(Enum))
 
     sym.exists &&
-    !sym.isAbsent() &&
+    !sym.isAbsent(canForce = false) &&
     !sym.isPrimaryConstructor &&
     sym.sourceSymbol.exists &&
     (!sym.is(Package) || sym.is(ModuleClass)) &&

presentation-compiler/src/main/dotty/tools/pc/completions/Completions.scala

@@ -590,7 +590,7 @@ class Completions(
         else false,
       )
       Some(search.search(query, buildTargetIdentifier, visitor).nn)
-    else if completionMode.is(Mode.Member) then
+    else if completionMode.is(Mode.Member) && query.nonEmpty then
       val visitor = new CompilerSearchVisitor(sym =>
         def isExtensionMethod = sym.is(ExtensionMethod) &&
           qualType.widenDealias <:< sym.extensionParam.info.widenDealias

presentation-compiler/test/dotty/tools/pc/tests/completion/CompletionExtensionSuite.scala

@@ -228,6 +228,10 @@ class CompletionExtensionSuite extends BaseCompletionSuite:
         |""".stripMargin
     )
 
+  /**
+   * For optimization, we don't show any completions here as it would bring
+   * every extension method into the completion list.
+   */
   @Test def `simple-empty` =
     check(
       """|package example
@@ -238,11 +242,13 @@ class CompletionExtensionSuite extends BaseCompletionSuite:
          |
          |def main = 100.@@
          |""".stripMargin,
-      """|incr: Int (extension)
-         |""".stripMargin,
+      "",
       filter = _.contains("(extension)")
     )
 
+  /**
+   * Some as above, but for implicit completions.
+   */
   @Test def `simple-empty-old` =
     check(
       """|package example
@@ -253,8 +259,7 @@ class CompletionExtensionSuite extends BaseCompletionSuite:
          |
          |def main = 100.@@
          |""".stripMargin,
-      """|testOps(b: Int): String (implicit)
-         |""".stripMargin,
+      "",
       filter = _.contains("(implicit)")
     )